Comments (8)
Whoops! - missed that in my review! Thanks for the report - we'll get that fixed next week!
from moodle-local_cohortauto.
My apologies for not catching more opportunities to internationalise the strings earlier. I removed some string hard-coding from the original plugin, but I appear to have added some of my own. I will be more careful about that in future.
From an initial look-through I have found these two things to fix, and I will work on them in the morning:
- https://github.com/catalyst/moodle-local_cohortauto/blob/master/view.php#L86
cli_writeln()
functions in https://github.com/catalyst/moodle-local_cohortauto/tree/master/cli
I will also conduct a more careful check once that is done.
If you can see any other places where correction is obviously needed, do please let me know and I will address them as promptly as I can. Thank you!
from moodle-local_cohortauto.
@DrCuriosity - Amos doesn't cope with string concatenation- eg 'line1'.'line2'
from moodle-local_cohortauto.
Eg:
from moodle-local_cohortauto.
Understood. Will make that conversion, and do it as a PR for review.
from moodle-local_cohortauto.
Code updated, and version reuploaded to moodle.org. Is there anything further that needs to be done in order for AMOS to pick up the change?
from moodle-local_cohortauto.
nope that should be it - thanks David! - @germanvaleroelizondo - let us know if you have any further issues!
from moodle-local_cohortauto.
Hi,
Strings are now available in AMOS for translation.
Thanks.
from moodle-local_cohortauto.
Related Issues (20)
- "$PAGE->context was not set" when performing OAuth2 login HOT 7
- Looking for a way to create cohort based on user creation time HOT 6
- Force cohorts to update without logging in users HOT 2
- Can't delete generated cohorts HOT 1
- Support for 3.11? HOT 1
- Deprecated: Required parameter $result follows optional parameter $prefix in HOT 1
- allow match on cohortid HOT 1
- Compatible moodle 4.X ? HOT 1
- UI checks making unit tests failure HOT 1
- sync_users.php not working in moodle 4 HOT 3
- Massive Server Load HOT 7
- NULL value for column idnumber is not allowed on Moodle 4.1+ anymore HOT 1
- Problems when using the Plugin HOT 1
- Moodle 4.0 or 4.1 HOT 1
- Prevent warnings on empty emails HOT 2
- warning for $PAGE->context not set when logging in user HOT 2
- settings.php: curious why this plugin is not listed in the local plugin settings HOT 1
- cli/sync_users.php: show username being processed only if necessary HOT 1
- cli/sync_users.php cron_setup_user() function is deprecated HOT 2
- Moodle 3.9 issues HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moodle-local_cohortauto.