Coder Social home page Coder Social logo

Comments (3)

piotr-dziubecki avatar piotr-dziubecki commented on July 1, 2024

@Fraser999 to ping @afck about it

from casper-node.

piotr-dziubecki avatar piotr-dziubecki commented on July 1, 2024

@afck : Well, it's a regression test. So it's fine to delete it as long as nobody reintroduces the bug. 😄
In this case I actually think it's fine to remove it. In fact, I'd remove the optimization from the code that allows skipping validation for blocks that are both empty and contain accusations. If all blocks are always getting validated without exception there's no danger of bringing back this bug.
So maybe just remove ConsensusValueT::needs_validation, and assume it's always true.

from casper-node.

Fraser999 avatar Fraser999 commented on July 1, 2024

As discussed in standup today, we'll instead implement a fix for the test and retain the original optimisation in the code.

from casper-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.