Comments (4)
@Fraser999 might this be a good task for Austin when he comes on board?
from casper-node.
Given that we don't have a strong use case for this, and that it will take a fair amount of specialized testing, I don't think this is worth doing right now. Recommend moving to backlog and revisit in Q3.
from casper-node.
I think we should create subdirs named after genesis hash and not network name. Network name doesn't need to be unique – there can be two networks with the same name and different genesis hashes that would be incompatible.
from casper-node.
I think we should create subdirs named after genesis hash and not network name. Network name doesn't need to be unique – there can be two networks with the same name and different genesis hashes that would be incompatible.
I see your point, but the main issue is that the genesis hash isn't persisted across upgrades in a way in which the Storage
component or the ChainspecLoader
component could easily access it. When a non-genesis version of node starts up, it pretty much immediately needs to know where to access the DB files from the previous run.
I think since this ticket is non-critical, i.e. it's designed to help users avoid a simple footgun, it's probably enough to just use the network name here.
Of course, if I'm missing an easy way for the genesis hash to be given to the Storage
constructor of a non-genesis version, I'd be inclined to agree with your suggestion.
from casper-node.
Related Issues (20)
- Review max_request_size_bytes and max_response_size_bytes binary port config
- Send custom error message payloads in the binary port
- Investigate potentially flaky Highway Zug rewards tests
- Joiner issue for 1.6 HOT 1
- Wrong documentation for enable_contract_version
- Distributing rewards for signatures sometimes fail if the validator dropped from the validator list
- BlockValidator can sometimes drop responders without responding HOT 1
- Create a reactor test that checks that new 2.0 rewards are correctly distributed to inactive validators
- Move values that can affect size of the BinaryPort request to chainspec
- Create a tool for direct communication with binary port
- Adjust cost values for contract messages FFI parameters
- Write reactor tests for checking transaction payments HOT 1
- Unintended speed dependence in should_have_diverse_proposable_blocks_with_stocked_buffer test
- Add a dedicated balance request to the binary port and expose hold information in a new RPC endpoint
- Improve Ticket handling in consensus code
- Investigate the flaky test - "should_fetch_from_multiple_peers"
- Add mechanism to increase efficiency of reconnection process after upgrade
- Update Condor (2.0) Changelogs
- Change casper-node logs from RPC/binary-port to INFO if they return errors to users
- Bug report: The state_get_entity response does not include a method to retrieve the named keys of an addressable entity. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from casper-node.