Coder Social home page Coder Social logo

Comments (7)

casey-c avatar casey-c commented on September 23, 2024

I appreciate the feedback a ton, thank you! This is something I was originally worried about while implementing since I didn't have a decent way to test it on my own, and I'm sorry to hear that it happened.

I think some of my code tries to let the UI scale up to the current resolution, but a whole lot of it doesn't (mostly due to me not being sure if the "fix" I was doing was actually doing anything at all). Currently the approach I've been trying to do is to compute everything at 1920x1080 and then scale up using a scaling factor provided by the base game (this scaling factor is required to be set at every render call, and I've been super lazy in omitting it). I am also a bit worried that the scaling factor as is won't handle super wide resolutions. I will have to look into the base game code a bit more and investigate how they do it correctly :)

If you'd be willing to assist in providing some screenshots so I can try and see what's happening - it would be super helpful for me to debug.

Can you provide screenshots of the following screens (you can use the steam screenshot functionality with F12 and then comment a reply with the links, or use any other method like uploading to imgur or something):

  • Config menu (MainMenu->Mods->InfoMod->Config)
  • Monster compendium (shift right click a monster) - [I'm assuming the shift right click monster works at least - hopefully the ultra wide doesn't affect the hitboxes]
  • In game potion tracker settings (click the [?] box)

In theory these should all be centered, nice looking, and readable, but I imagine they end up looking really incorrect, and I'd like to see exactly how wrong they turned out. (And hopefully spot the places where I've implemented the "fix" and see if it did anything)

I will work towards getting out a temporary workaround with the menu option going to screen resolution instead of a hardcoded 1920x1080, to hopefully get that piece working for you :)

from spiretool-infomod.

casey-c avatar casey-c commented on September 23, 2024

Followup: did some more diving into the source code to see if I could find out how the devs handle ultrawide resolutions. It seems like the "fix" I have in mind should theoretically work. I've been working on a very large scale rewrite of the whole rendering process and will apply it there, and hopefully you won't have any more issues. Those updates should hopefully trickle back down into InfoMod in the next 2-4 weeks (it's been a pretty huge undertaking).

I'm still curious to see what it looks like currently (My guess would be absolutely unreadable and unusable, but I don't know for sure - I might be surprised). It would also help me narrow down a bit where I need to apply the fixes :)

from spiretool-infomod.

10000turtles avatar 10000turtles commented on September 23, 2024

from spiretool-infomod.

casey-c avatar casey-c commented on September 23, 2024

Hey - thanks for the screenshots. I've released a tiny update 0.5.8 as a first attempt to fix this issue. Again, I couldn't test it against a high resolution monitor so I'll need your assistance there. Please take a look around at it and let me know what you see (what's working/what's broken/etc.)!

from spiretool-infomod.

casey-c avatar casey-c commented on September 23, 2024

@10000turtles

Hi - can you confirm if the 0.5.8 release fixes any of the issues you encountered? I would like to know if those attempts succeeded so I can proceed in that direction / try a new one if needed. Thanks!

from spiretool-infomod.

kordra avatar kordra commented on September 23, 2024

I can confirm that the menu issues seem fixed but when you hover over the ? it still showing half the dialog off screen at 1440p.

from spiretool-infomod.

casey-c avatar casey-c commented on September 23, 2024

Thanks for the feedback! I definitely forgot to apply the fix to the tool tip boxes (which is a bit sad given that the majority of info mod takes place in tool tips haha - it's a pretty big oops). I will try and push a patch sometime this upcoming week to hopefully get it fixed.

I apologize for the late response / lack of updates - been a bit busy with real life stuff!

from spiretool-infomod.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.