Coder Social home page Coder Social logo

Comments (8)

hellobrian avatar hellobrian commented on May 25, 2024

Npm publish is done. Need more time to figure out check-in for build files. For now, all pull requests can do npm run build

from carbon-icons.

aagonzales avatar aagonzales commented on May 25, 2024

Not a priority but @joshblack could you check this out when you get a chance? Not sure if this has been resolved already.

from carbon-icons.

joshblack avatar joshblack commented on May 25, 2024

@aagonzales yeah for sure! Could you help fill me in on context for this? Might also be worth talking about the icon authoring flow you had mentioned earlier.

from carbon-icons.

aagonzales avatar aagonzales commented on May 25, 2024

@joshblack I honestly have no clue what the context is here. This is beyond my technical knowledge. Maybe @marijohannessen or @tw15egan knows what Brian was talking about.

from carbon-icons.

aagonzales avatar aagonzales commented on May 25, 2024

Or since this is in the public github maybe @hellobrian would be nice enough to give some context.

from carbon-icons.

hellobrian avatar hellobrian commented on May 25, 2024

Hey! basically, this issue is about automating the build process for any SVG icons contributed to this repo. In other words, I wanted a way for Travis CI to execute the npm run build script and commit those built files to this repo automatically.

I ask contributors to either make a pull request, adding any new icons to the src directory (or I add it for them). Once merged into master, I run the build script (npm run build) to optimize the SVG file and then I make a new commit, which triggers all the npm publishing stuff via semantic-release.

I wasn't able to figure out how to do this properly when I was working on this repo, so that's the origin story of this issue. Let me know if that makes sense, and I'm happy to answer any other questions y'all may have.

from carbon-icons.

joshblack avatar joshblack commented on May 25, 2024

@hellobrian thanks for responding! 😄

Do the build artifacts need to be checked into source control, or do they just need to be published with the package itself?

from carbon-icons.

hellobrian avatar hellobrian commented on May 25, 2024

@joshblack Correct, I don't think the build artifacts need to be checked into source control (everything in dist); the build artifacts just need to be published with the package itself.

from carbon-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.