Comments (8)
Npm publish is done. Need more time to figure out check-in for build files. For now, all pull requests can do npm run build
from carbon-icons.
Not a priority but @joshblack could you check this out when you get a chance? Not sure if this has been resolved already.
from carbon-icons.
@aagonzales yeah for sure! Could you help fill me in on context for this? Might also be worth talking about the icon authoring flow you had mentioned earlier.
from carbon-icons.
@joshblack I honestly have no clue what the context is here. This is beyond my technical knowledge. Maybe @marijohannessen or @tw15egan knows what Brian was talking about.
from carbon-icons.
Or since this is in the public github maybe @hellobrian would be nice enough to give some context.
from carbon-icons.
Hey! basically, this issue is about automating the build process for any SVG icons contributed to this repo. In other words, I wanted a way for Travis CI to execute the npm run build
script and commit those built files to this repo automatically.
I ask contributors to either make a pull request, adding any new icons to the src
directory (or I add it for them). Once merged into master
, I run the build script (npm run build
) to optimize the SVG file and then I make a new commit, which triggers all the npm publishing stuff via semantic-release.
I wasn't able to figure out how to do this properly when I was working on this repo, so that's the origin story of this issue. Let me know if that makes sense, and I'm happy to answer any other questions y'all may have.
from carbon-icons.
@hellobrian thanks for responding!
Do the build artifacts need to be checked into source control, or do they just need to be published with the package itself?
from carbon-icons.
@joshblack Correct, I don't think the build artifacts need to be checked into source control (everything in dist
); the build artifacts just need to be published with the package itself.
from carbon-icons.
Related Issues (20)
- pictogram request - Process Digitalization HOT 3
- Some icons are missing from the Iconography page on Carbon Design System website HOT 7
- Contribution: Tablet HOT 1
- Contribution: Mobile HOT 10
- Request: SDK icon HOT 11
- Contribution: Legend HOT 4
- iconRenew not exported HOT 1
- Contribution: City Icon Hamburg HOT 4
- IDL Library missing filter icon 16px HOT 1
- IBM Planning Analytics Pictogram Approval HOT 3
- Request: playbook icon HOT 1
- iconFolderAdd is missing, same as iconFolder HOT 1
- Contribution: ibm cloud VPS locations
- Create add-on package for animated icons HOT 1
- Unable to find AnalyticsReference icon in version 7 HOT 1
- github
- Contribution - Status icon
- Delete icon missing under nodemodules HOT 1
- New icon request for mobile, multi channel and social ads HOT 4
- Create migration docs and deprecate package HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carbon-icons.