Coder Social home page Coder Social logo

Comments (5)

mbaranovski avatar mbaranovski commented on August 25, 2024 1

Hey guys! I've just noticed your repo while searching for some Open Source project to contribute to. Anyway, how about adding a time stamp with date to the file so it looks like this for example: carbon_17-10-03_16:54.png or similar format? It will also work while sorting files on disk by name.

from carbon.

briandennis avatar briandennis commented on August 25, 2024

Great idea! We should definitely add support for this

from carbon.

yeskunall avatar yeskunall commented on August 25, 2024

I'm glad I'm not the only one who thinks this is worth the effort. 😄

A few things that I would like to add to this:

  • Chrome allows you to turn on an option in settings that prompts the user each time they download a file, so for users who have already turned this option on, this "feature" is already implemented. I'm not so sure about the other browsers, however. In any case, if we are to implement this feature, we shouldn't be depending on the user to have this option enabled
  • From caniuse.com, the HTML5 download attribute is largely supported on all recent builds of modern browsers, so that's a good thing for us (but there are certain mobile builds that don't have support for it. However, I can't imagine a use case where someone would use this app through their phones, but hey, who knows? 🤷‍♀️)

So here's my suggestion: how about we add a field where the user can enter the file name for their screenshot? Thoughts? Comments? Feedback? I'm all ears 👂

from carbon.

mfix22 avatar mfix22 commented on August 25, 2024

Hey @bombellos thanks for finding us, and we would love for you to contribute!

@yeskunall thanks for the discussion. After further consideration, we have decided that the saving behavior is good enough for the use case. Chrome currently does the "Save As" dialog, and for other browsers a (#) gets appended which is good for different versions.

Plus there are other more fun issues to work on 🤗

from carbon.

yeskunall avatar yeskunall commented on August 25, 2024

Sure thing! But I just want to point out that the "Save As" dialog (in Chrome) isn't on for most users by default.

This is my Chrome settings page on my work PC:

capture

I can't say the same about other browsers, tho 🤔 (just thought you guys should know)

from carbon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.