Comments (9)
@briandennis, thanks it works fine, you are awesome !
from carbon.
@nozzlegear opened #28 so you can track it (:
from carbon.
Also does not work in Edge (neither does the Tweet Image
button).
from carbon.
@micnic I pushed a fix, it should be working on Firefox now.
@nozzlegear Is the Save Image
button working on Edge now? I can check myself later today, but don't have access to Edge at the moment...
from carbon.
@micnic glad I could help!
from carbon.
Going to close this. Will reopen another issue if the problem on Edge persists
from carbon.
@briandennis I've done some investigating with Edge and it looks like the dom-to-image
package isn't tested in and doesn't support Edge (or Safari I guess): tsayen/dom-to-image#78. Specifically the .toPng
function fails with Edge complaining that the canvas is dirty.
I switched out .toPng()
with .toSvg()
which got me further, the browser was able to create the data URL. However I was unable to actually navigate to that data URL, download it or even just copy it to my clipboard to navigate there manually. It would just crash Edge instead.
Not sure how much work you want to put into this issue, it's probably just easier to add a note that Carbon doesn't support Edge!
from carbon.
@nozzlegear thanks so much for investigating. We plan to replace dom-to-image
with a cross-browser solution. We really appreciate the work you did.
from carbon.
No problem! Looking forward to a cross browser Carbon.
from carbon.
Related Issues (20)
- Improve Documentation on how to add a new Language
- Migration to TS
- Fix #1405 for image cutoff breaks Chrome, Brave on Mac and older Safari
- Drop shadow preview does not match export (Safari 16.5.1)
- Syntax highlighting support for Microsoft Dynamics Business Central AL language.
- Incorrect final line padding
- Carbon app is not running locally HOT 2
- Auto-paste from Clipboard
- URL does not contain information about custom formatting (e.g. coloring)
- Markdown support with option to remove markdown characters
- Diff command support
- Unified diff output broken for some theme presets HOT 1
- Save not updating existing snippets HOT 3
- Formatting issue HOT 3
- Screenshot formatting is broken for hanging indent code HOT 2
- Cursor not visible with dark background HOT 2
- Feature request: increase spacing between line numbers and code HOT 2
- feature request: add new GitHub Monaspace font to font-selection
- Preview does not match export HOT 2
- "Copy as image" isn't working in Safari HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carbon.