FileChanged BC break 4.X => 5.X about captainhook

[sebastianfeldmann]

It is possible but the implementation must be different.
You have to check the index to get the files "that will change" in the upcoming commit.
This is done "manually" inside some Hooks like the linting hook.
Currently there is no Condition implementation because I haven't figured out a nice way of naming an implementing it without breaking the current FileChanged implementations or copy pasting everything :/

[sebastianfeldmann]

I just released version 5.2.0 with the new Staged All and Any conditions that you can use in pre-commit hooks.

[sebastianfeldmann]

You are right, now FileChanged is only executed on post-merge and post-checkout.
This is because FileChanged does not work for any other hook.

The way FileChanged\All and FileChanged\Any are implemented make them only applicable for post-merge and post-checkout hooks.

Both of them are using git diff to detect the changed files. And only post-checkout and post-merge provide the required IDs to get a valid response.

It was "working" with other hooks before but not working at all, the conditions where always false.

[boesing]

So there is no diff in a pre-commit hook?
Thats interesting.

Any suggestion how to receive the diff in a pre-commit hook of those files which are contained within the commit?

Would also know if there is a way to get all changed files in a pre-push hook. Having a diff between HEAD and repository version would be great.

[boesing]

I'll give it a try and if I found a way, I'll contribute back. Thanks so far.

[sebastianfeldmann]

There is a condition specific for pre-commit named FilesStaged\OfType it works similar as FilesChanged\Any. The condition works in a pre-commit hook and will only execute the hook if a file of a given file suffix is staged for commit. I'll add Any and All there today.