[feature] condition about changed files at pre-push about captainhook

[CircleCode]

There are the Conditions located under CaptainHook\App\Hook\Condition\FileChanged\* they are suited to use for pre-push

It was not stated in the doc (they are flagged only for post-checkout / post-merge), but the code indeed indicates they should work on pre-push.
I will make some tests to see if they fulfill my needs, thanks.
Anyway, after my tests, I may update documentation :-)

[sebastianfeldmann]

There are the Conditions located under CaptainHook\App\Hook\Condition\FileChanged\* they are suited to use for pre-push

[CircleCode]

before working on documentation, I am a bit confused about the way the before-push hook works:

If the pushed reference is not the current HEAD (or if we push several references), the condition FileChanged\OfType is evaluated against pushed reference(s), but the hook is then run against the working directory. I find this surprising because I would expect the before-push to prevent pushing broken code, but here it can't prevent anything on the pushed references…

Additionnaly, CaptainHook\App\Hook\Condition\FileChanged\* has 3 classes: OfType, All, Any, but only OfType is compatile with pre-push

[sebastianfeldmann]

Additionnaly, CaptainHook\App\Hook\Condition\FileChanged\* has 3 classes: OfType, All, Any, but only OfType is compatile with pre-push

Yes, at the moment that is true, because getting a list of files changed works differently on pre-push, post-merge, post-checkout, and post-rewrite :)

I have to clean that up at some point :)

[sebastianfeldmann]

Oh looks like I did that, I just didn't update the Restrictions.

So after my next push All and Any should also work for pre-push.

[sebastianfeldmann]

Fixed with 5.15.4 docs updates as well ;)