Comments (6)
There are the
Conditions
located underCaptainHook\App\Hook\Condition\FileChanged\*
they are suited to use forpre-push
It was not stated in the doc (they are flagged only for post-checkout / post-merge), but the code indeed indicates they should work on pre-push.
I will make some tests to see if they fulfill my needs, thanks.
Anyway, after my tests, I may update documentation :-)
from captainhook.
There are the Conditions
located under CaptainHook\App\Hook\Condition\FileChanged\*
they are suited to use for pre-push
from captainhook.
before working on documentation, I am a bit confused about the way the before-push hook works:
If the pushed reference is not the current HEAD (or if we push several references), the condition FileChanged\OfType
is evaluated against pushed reference(s), but the hook is then run against the working directory. I find this surprising because I would expect the before-push to prevent pushing broken code, but here it can't prevent anything on the pushed references…
Additionnaly, CaptainHook\App\Hook\Condition\FileChanged\*
has 3 classes: OfType
, All
, Any
, but only OfType
is compatile with pre-push
from captainhook.
Additionnaly,
CaptainHook\App\Hook\Condition\FileChanged\*
has 3 classes:OfType
,All
,Any
, but onlyOfType
is compatile withpre-push
Yes, at the moment that is true, because getting a list of files changed works differently on pre-push, post-merge, post-checkout, and post-rewrite :)
I have to clean that up at some point :)
from captainhook.
Oh looks like I did that, I just didn't update the Restrictions
.
So after my next push All
and Any
should also work for pre-push
.
from captainhook.
Fixed with 5.15.4
docs updates as well ;)
from captainhook.
Related Issues (20)
- Support for Relative Path to CaptainHook Executable in Generated Hooks HOT 5
- Allow Staged and Changed files condition to define diff-filter HOT 1
- PHP Fatal error: Argument #2 ($filter) must be of type array HOT 7
- InjectIssueKeyFromBranch does not work as expected HOT 10
- http://captainhook.info is not available anymore? HOT 1
- Support Symfony 7 HOT 2
- $CHANGED_FILES placeholder is empty for first push HOT 1
- [FEATURE-REQUEST] New placeholder `ALL_CHANGED_FILES` HOT 17
- Docker mode not working? HOT 9
- Linting fails when it shouldn't? HOT 3
- Default config file does not work HOT 3
- Error 'The "--input" option does not exist' when rerunning the hooks HOT 1
- captainhook/captainhook-phar failing, prefer captainhook/captainhook in README HOT 3
- Running Hooks in Subrepositories fails HOT 10
- Execute PHAR hook installation without an autoloader HOT 9
- [Feature] Parallel execution of actions HOT 1
- [Bug?] Pre-push hook failing with ddev/docker HOT 4
- Installation not working behind a proxy
- Install fails with a missing class HOT 13
- Hello HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from captainhook.