downloadFile should not return when statusCode is not in 2xx range about http

[kevinboosten]

I believe it was modeled after fetch behavior, which only rejects if there's an issue with the connection. That being said, the behavior should be the same across all platforms.

For the "Http.request" part I can agree. The downloadFile method should reject or we should add the statuscode in the response so the user can decide what to do with it. But then the method should not create a file on filesystem.

[imhoffd]

Agreed, downloadFile is a higher level method.

[kevinboosten]

You could also argue about if the following code should result in an error:

await Http.request({
   url: 'http://httpstat.us/404',
   method: 'GET'
});

I would expect this (if I compare it to the Angular HttpClient):
Http.request --> statuscode in 2xx range --> ✅
Http.request --> statuscode not in 2xx range --> ❌

This way people can, perhaps, more easily use this api without specifically having to interpret the statusCode. But I guess this has been implemented this way deliberately, right?

[imhoffd]

I believe it was modeled after fetch behavior, which only rejects if there's an issue with the connection. That being said, the behavior should be the same across all platforms.