Coder Social home page Coder Social logo

Comments (3)

simskij avatar simskij commented on June 16, 2024

Yeah, this change makes sense to me!

from charming-actions.

ca-scribner avatar ca-scribner commented on June 16, 2024

If there's any worry about always publishing to branches, a compromise would be an optional upload-to-branch-label argument (or something with a better name). If set, then the action would only upload to branches if the PR has that label (this way PRs can opt-in to branch publishing when it is needed). If unset, then the action would always publish to a branch

from charming-actions.

simskij avatar simskij commented on June 16, 2024

I think it's fine without that extra precaution as remote PRs won't have access to secrets and hence will fail, so to have this work, repos that want to publish to branches will have to enforce a feature branch based workflow rather than forks.

from charming-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.