Coder Social home page Coder Social logo

Comments (20)

osteinhauer avatar osteinhauer commented on July 20, 2024

The trick is that in gradle build the war ist repackaged as webjar (https://github.com/Zapata/camunda-spring-boot-embedded/blob/master/camunda-webapp-webjar/build.gradle).

IMHO: A spring boot starter should never do such "hacks". And the example I have provided is very ugly too.

But the idea to have an webjar is great. We should ask if the webapp module can provided an webjar.

from camunda-bpm-spring-boot-starter.

hawky-4s- avatar hawky-4s- commented on July 20, 2024

Valid point. I'll take care of that.

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

Thanks for that. Until there is no idea to include the webapp in a nice way the starter should not be used by anyone.

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

Well, then this should not be part of the master branch anymore ... we should aim for a soon POC release so we can play around with the stack, and everything thats not supposed to work is just confusing ... so maybe create a feature branch and put it on hold?

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

feature branch is a good idea. We should do that after we have all agreed to the multi module.

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

Any news on the web jar deliverable from platform? Is it realistic to have this in 7.4? What needs to be done?

from camunda-bpm-spring-boot-starter.

meyerdan avatar meyerdan commented on July 20, 2024

Pull request ? :=)

from camunda-bpm-spring-boot-starter.

 avatar commented on July 20, 2024

Basically just creating a maven project inside the camunda-webapp
project 1, which repackages the bundled webapp as web-jar as in 2.

On 09.09.15 11:25, Jan Galinski wrote:

Any news on the web jar deliverable from platform? Is it realistic to
have this in 7.4? What needs to be done?


Reply to this email directly or view it on GitHub
#3 (comment).

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

I just created camunda/camunda-bpm-webapp#5

Please check my remarks, I am not quite happy with the result, but cant figure out whats missing, I guess thats because I need some sleep ...

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

If you have time, please check the PR camunda/camunda-bpm-webapp#5 comments .... Daniel is asking me if the generated output is what I need, and honestly: I do not know ... I suppose there is some stuff missing ...

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

Even when we have the webjar, this will only be applicable for 7.4, so I moved it to milestone 2.0

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

I started the following: provide a camunda-bpm-spring-boot-webjar inside this repo. This is exactly the same as the webjar PR for 7.4, but we generate it ourselves, so we can use it with 7.3 right away. for 7.4 this can be removed.
I also locally created a c-b-s-b-starter-webapp where this webjar is used and am currently integrating the ServletFilter from the zapata approach (using Christians branch). Hope to get this running soon.

from camunda-bpm-spring-boot-starter.

abrass avatar abrass commented on July 20, 2024

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4 including the cockpit as a web-jar?

greetz

Anton

from camunda-bpm-spring-boot-starter.

 avatar commented on July 20, 2024

Hi Thomas,

There is an ongoing PR for 7.4 webapp and we will probably build a 7.3
Version especially for the Spring Boot Starter inside this project.

Cheers
Christian

Gesendet mit AquaMail für Android
http://www.aqua-mail.com

Am 3. Oktober 2015 16:45:49 schrieb Anton BNrass [email protected]:

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4
including the cockpit as a web-jar?

greetz

Anton


Reply to this email directly or view it on GitHub:
#3 (comment)

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

If you don't want to wait until Cockpit is supported you can have a look at https://github.com/camunda/camunda-bpm-spring-boot-starter/tree/Embed_Camunda_WebApp_%233/camunda-webapp-spring-boot-starter and do the configuration on your own. Be aware that this isn't nice at all. That is why it isn't integrated yet. See the discussion above.

Am 03.10.2015 um 16:45 schrieb Anton BNrass [email protected]:

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4 including the cockpit as a web-jar?

greetz

Anton


Reply to this email directly or view it on GitHub.

from camunda-bpm-spring-boot-starter.

hawky-4s- avatar hawky-4s- commented on July 20, 2024

Okay, I merged the PR on Camunda-Webapp

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

The webjar is integrated now but not tested well.

Beside the webjar isn't bundled very nice:

The resources should be located in META-INF/resources like http://www.webjars.org and https://spring.io/blog/2014/01/03/utilizing-webjars-in-spring-boot describes. Having that it wouldn't be necessary to add all resources from the classpath root like CamundaBpmWebappAutoConfiguration.java does: registry.addResourceHandler("/**").addResourceLocations("classpath:/")

Maybe another one has an idea to get the resources served in a better way?

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

This feature seems to work and will be contained in release 1.1.0
Bugs and features will go in separate issues

from camunda-bpm-spring-boot-starter.

jangalinski avatar jangalinski commented on July 20, 2024

Question (cant test it myself right now): If I use starter-webapp and starter-rest together, can I still access the rest-api, or is that masked by the webapp resource?

from camunda-bpm-spring-boot-starter.

osteinhauer avatar osteinhauer commented on July 20, 2024

Just created an example (rest-api-and-webapp https://github.com/osteinhauer/camunda-spring-boot-starter-examples/tree/master/rest-api-and-webapp) because I was interested too. I figured out that both can be used in parallel.

Am 20.01.2016 um 10:01 schrieb Jan Galinski [email protected]:

Question (cant test it myself right now): If I use starter-webapp and starter-rest together, can I still access the rest-api, or is that masked by the webapp resource?


Reply to this email directly or view it on GitHub #3 (comment).

from camunda-bpm-spring-boot-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.