switch to jdk 1.6 about camunda-bpm-spring-boot-starter

[osteinhauer]

I would prefer to use 1.8 features but in a weak moment I have set the version to 1.7.

Spring boot recommends to use something newer to 1.6 but is still 1.6 compatible.

In fact this starter should "only" configure some beans. The question should be: use 1.6 or 1.8?

[osteinhauer]

IMHO what we should do is: use 1.6 for camunda-spring-boot-starter and 1.8 for examples.

[meyerdan]

+1 for maintaining 1.6 compatibility.

[jangalinski]

Ok, but when we stick to 1.6 i would vote against two different jdks in this repo. Messes up ide and maven. The examples should not need much code anyway, so they would not benefit enough to justify the extra efford. Later we could provide 1.8 examples in a different setup.

[osteinhauer]

ok. use 1.6 only.

Am 24.06.2015 um 08:58 schrieb Jan Galinski [email protected]:

Ok, but when we stick to 1.6 i would vote against two different jdks in this repo. Messes up ide and maven. The examples should not need much code anyway, so they would not benefit enough to justify the extra efford. Later we could provide 1.8 examples in a different setup.

—
Reply to this email directly or view it on GitHub.

[jangalinski]

I edited this issue to reflect that decision

[jangalinski]

I am having trouble when writing a test that uses the Spring-Test Runner, because it does a component scan and fails on the provided servlet-2.4 jar which requires Java 7.

Seems like we need to change the embedded tomcat: http://docs.spring.io/spring-boot/docs/1.2.4.RELEASE/reference/htmlsingle/#howto-use-java-6

I will switch to tomcat 7 for testing http://docs.spring.io/spring-boot/docs/1.2.4.RELEASE/reference/htmlsingle/#howto-use-tomcat-7

[osteinhauer]

Hi Jan. Can you provide an example?

[jangalinski]

I will commit my failing attempt as a branch tonight

[jangalinski]

I do not need an example:

This is what I get when I start example-web/Application http://pastebin.com/gcjWZeGX

This is what I get when I run the CamundaBpmRestIT http://pastebin.com/nUwwwVQi

Seems to me like stated above that with the springweb bundle we either need >=Java7 or switch to tomcat 7.

Does this work on your machines?

I think Tomcat 8 needs JDK 7. But interesting that it affects the EJB
annotation. I will test it today.

Gesendet mit AquaMail für Android
http://www.aqua-mail.com

Am 4. August 2015 08:04:12 schrieb Jan Galinski [email protected]:

I do not need an example:

This is what I get when I start example-web/Application
http://pastebin.com/gcjWZeGX

This is what I get when I run the CamundaBpmRestIT http://pastebin.com/nUwwwVQi

Seems to me like stated above that with the springweb bundle we either need

=Java7 or switch to tomcat 7.

Does this work on your machines?

---

Reply to this email directly or view it on GitHub:
#13 (comment)

I can reproduce the issue locally.
ServletSpec and so on are compiled with JDK 7. So we should rewrite the
project to compile stuff with JDK6 binary as target format and running
the examples with JDK 7.
I personally wouldn't switch to Tomcat 7.
WDYT?

On 04.08.15 08:04, Jan Galinski wrote:

I do not need an example:

This is what I get when I start example-web/Application
http://pastebin.com/gcjWZeGX

This is what I get when I run the CamundaBpmRestIT
http://pastebin.com/nUwwwVQi

Seems to me like stated above that with the springweb bundle we either
need >=Java7 or switch to tomcat 7.

Does this work on your machines?

—
Reply to this email directly or view it on GitHub
#13 (comment).

[jangalinski]

My opinion: JDK6 has been outdated for a while now. I understand why camunda has to support the core product for 1.6, but I dont believe that anyone considering a Spring-Boot/microservice environment will use 1.6. So we should drop legacy support and create something new and shiny. I'd even prefer to go to 1.8 so we can use the language features. Besides: 1.7 is unsupported as of July 15.

[osteinhauer]

I have adjusted the maven dependencies with a "java6" profile which can be removed when using a later version. In fact this is the same discussion as above: at compile time java version 1.6 is fine. But I accept @jangalinski that versions later than 1.6 will be used at runtime.

So I would still prefer to divide the starter (1.6), starter integration tests (1.8) and examples (1.8 )to have a clean setup.

[hawky-4s-]

I would propose to use the maven based activation for JDKs instead of applying activeByDefault on the jdk6 profile. Something aIong the lines <activation><jdk>1.6</jdk></activation>.
I am ok with using JDK 8 for the example, but the starter should stay 1.6.

[osteinhauer]

Activation by jdk would be fine.

[osteinhauer]

@hawky-4s- would you please verify that the verify goal is in the build pipeline? Without the *IT tests will not be executed. So there will be early feedback if anything is wrong for jdk 1.6

It is and build was ok.

On 10.08.15 16:30, osteinhauer wrote:

@hawky-4s- https://github.com/hawky-4s- would you please verify that
the verify goal is in the build pipeline? Without the *IT tests will
not be executed. So there will be early feedback if everything is fine
for jdk 1.6

—
Reply to this email directly or view it on GitHub
#13 (comment).

[osteinhauer]

cool. THX!

[jangalinski]

A lot of trouble to go through just to keep 1.6 ... but the ITests are working now. How do you develop right now? Is the project in your IDE set to 1.6 or 1.8?

[osteinhauer]

My IDE (Eclipse) compiles with 1.6 and executes with 1.8.

[hawky-4s-]

Could all please test if this works for you with JDK6? I am unable to run the complete project on OSX because the Apple JDK6 breaks with PermGen Space. Same on our Jenkins when using Oracle JDK6.

[jangalinski]

not before 21h ...

[osteinhauer]

I have tested successfully with running maven 3 on jdk 8 and let the compiler and test plugins run with jdk 6. There is a profile to specify the jdk.

Cause I am in vacation I am unable to give more details for now.

Am 01.09.2015 um 11:23 schrieb Jan Galinski [email protected]:

not before 21h ...

—
Reply to this email directly or view it on GitHub.

[hawky-4s-]

Okay, works.