Coder Social home page Coder Social logo

Comments (16)

Tomnuyts avatar Tomnuyts commented on June 17, 2024 1

Problem is this can only be fixed in editorjs itself. So I forked the editorjs repo and made the necessary changes in the file to get it working. Hopefully they will approve the pull request or provide a fix themselves soon, so that I can switch back to the original repo.

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024 1

So then our best bet at the moment is to promote : codex-team/editor.js#2581

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024

Thanks for providing this amazing tool. It helps us to achieve a higher level of content creation of our users.

Thanks!

Enabling the inlineToolbar for the paragraph tool is not working for the link tool. Any clues how to solve this?
Here is a modified version of the example.html illustrating the problem: https://gist.github.com/foarsitter/ece006ffc97d41f5d2228a16f194b1ef

Hmm - This is strange.
I see the problem, but i cant work out whats causing it... It seems to be the same issue for the standard paragraph tool, and works when its not in a column.

I suspect there is something going on here with the way editor.js clears / deals with toolboxes. - It might be that nesting it causes some issues, or that the two instances search for the toolbar globally in the dom etc....

Ill keep looking.

from editorjs-columns.

bekiroeztuerk avatar bekiroeztuerk commented on June 17, 2024

Hello @calumk ,

Do you have a solution for this? I have the same problem.

from editorjs-columns.

aacoelho avatar aacoelho commented on June 17, 2024

I'm experiencing the same issue. Any news about this?

from editorjs-columns.

sureshHARDIYA avatar sureshHARDIYA commented on June 17, 2024
link_not_working.mp4

I am having same issue. Has anyone found the solution to this? Interestingly, when you copy past article with links from somewhere and paste, it sustains the link.

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024

Hello all - really sorry but no i never found a solution for this

when you copy past article with links from somewhere and paste, it sustains the link.

Yes, the issue is not with the data stored, it is probably related to having multiple instances of EditorJS in the same webpage. Maybe something like popups is stored globally

from editorjs-columns.

Tomnuyts avatar Tomnuyts commented on June 17, 2024

It's indeed true that this has to do with nesting editorjs instances.
Check out this pull request for more information about this issue: codex-team/editor.js#2581

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024

Thankyou for finding this issue

If you can propose a solutionor pull request to solve it somehow then I am very happy to implement

from editorjs-columns.

vFire avatar vFire commented on June 17, 2024

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

from editorjs-columns.

vFire avatar vFire commented on June 17, 2024

Problem is this can only be fixed in editorjs itself. So I forked the editorjs repo and made the necessary changes in the file to get it working. Hopefully they will approve the pull request or provide a fix themselves soon, so that I can switch back to the original repo.

Are there any chance that help me on how to change in the fork of editorjs? Much appreciated.

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

At the moment, I have no solution

I /think/ the fork at : https://github.com/loucass003/editor.js/tree/next will fix this.
You could try to clone and build this fork to see - I have not done this yet.

from editorjs-columns.

vFire avatar vFire commented on June 17, 2024

I just found once click in the any column area will trigger all editorjs instances saving... Maybe this will prevent the link popup editing modal from visibility.

from editorjs-columns.

Tomnuyts avatar Tomnuyts commented on June 17, 2024

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

At the moment, I have no solution

I /think/ the fork at : https://github.com/loucass003/editor.js/tree/next will fix this. You could try to clone and build this fork to see - I have not done this yet.

This fork does indeed fix the issue.

from editorjs-columns.

calumk avatar calumk commented on June 17, 2024

Looks like there is some progress on codex-team/editor.js#2581

Once it merges, i will test, make some updates, and push a new version

from editorjs-columns.

sureshHARDIYA avatar sureshHARDIYA commented on June 17, 2024

Depends on how soon PR owner makes requested changes

from editorjs-columns.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.