Coder Social home page Coder Social logo

Synchronised head methods about dart_nock HOT 4 OPEN

julescmay avatar julescmay commented on August 11, 2024
Synchronised head methods

from dart_nock.

Comments (4)

julescmay avatar julescmay commented on August 11, 2024 1

I have an idea to patch Registry.match method:

That was exactly my thinking.

I'm on it!

from dart_nock.

cah4a avatar cah4a commented on August 11, 2024

Hey @julescmay!

Thanks for the interesting question.

You are absolutely right that nock should support basic HTTP protocol features.
I'm sure that it shouldn't be done under the hood. Tests should always fully describe app behavior.

It could be done by adding Interceptor.withHead() method like so:

nock.get('/path')
    ..reply(200, "body", headers: {})
    ..withHead();

Currently, I don't have much time to do it by myself (I'm Ukrainian, don't have much free time for now).
If you have some time, I would really appreciate your PR.

from dart_nock.

julescmay avatar julescmay commented on August 11, 2024

I'm Ukrainian, don't have much free time for now

I understand. My heartfelt sympathies. Stay safe.

It could be done by adding Interceptor.withHead() method ...

IIUC http spec says that head should respond identically to get except for the lack of body. May I suggest: head response should be automatic unless:

  • there's a noHead() method on the interceptor;
  • there's another head interceptor on the same path.

If you have some time, I would really appreciate your PR...

Absolutely. Let me know your thoughts, and I'll get on it.

from dart_nock.

cah4a avatar cah4a commented on August 11, 2024

My heartfelt sympathies. Stay safe.

Huge thanks for the kind words!

noHead() method on the interceptor;

It's clear that it will be more intuitive to use.
I still have a feeling that .withHead() is more controlled and like it more, but I'm ok with reverse ideology too.

there's another head interceptor on the same path.

Because there is no "priority" for the Interceptors, I have an idea to patch Registry.match method: If no interceptor is found and the requested method is HEAD try to find corresponding GET request and create a new HEAD Interceptor.

from dart_nock.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.