Comments (4)
I have an idea to patch Registry.match method:
That was exactly my thinking.
I'm on it!
from dart_nock.
Hey @julescmay!
Thanks for the interesting question.
You are absolutely right that nock should support basic HTTP protocol features.
I'm sure that it shouldn't be done under the hood. Tests should always fully describe app behavior.
It could be done by adding Interceptor.withHead()
method like so:
nock.get('/path')
..reply(200, "body", headers: {})
..withHead();
Currently, I don't have much time to do it by myself (I'm Ukrainian, don't have much free time for now).
If you have some time, I would really appreciate your PR.
from dart_nock.
I'm Ukrainian, don't have much free time for now
I understand. My heartfelt sympathies. Stay safe.
It could be done by adding
Interceptor.withHead()
method ...
IIUC http spec says that head should respond identically to get except for the lack of body. May I suggest: head response should be automatic unless:
- there's a
noHead()
method on the interceptor; - there's another head interceptor on the same path.
If you have some time, I would really appreciate your PR...
Absolutely. Let me know your thoughts, and I'll get on it.
from dart_nock.
My heartfelt sympathies. Stay safe.
Huge thanks for the kind words!
noHead() method on the interceptor;
It's clear that it will be more intuitive to use.
I still have a feeling that .withHead()
is more controlled and like it more, but I'm ok with reverse ideology too.
there's another head interceptor on the same path.
Because there is no "priority" for the Interceptors, I have an idea to patch Registry.match method: If no interceptor is found and the requested method is HEAD try to find corresponding GET request and create a new HEAD Interceptor.
from dart_nock.
Related Issues (18)
- can't test HOT 2
- Response body mocking HOT 3
- Coverage HOT 9
- Post request not correctly mocked HOT 7
- Multiple requests HOT 12
- Null safety support HOT 4
- Impossible to write POST interceptor HOT 1
- Recording support? HOT 1
- Question: is it possible to not mock certain URLs? HOT 3
- matching uri with path-params HOT 1
- POST requests with body aren't working HOT 1
- Broken with Flutter 3 HOT 4
- Missing HttpClient methods since [email protected] HOT 1
- Using Nock outside of tests? HOT 1
- Timeout test with a delayed response? HOT 2
- .post() does not intercept if there is headers HOT 2
- Error: The non-abstract class '_Cookie' is missing implementations for these members: Cookie.sameSite HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart_nock.