Grunt modifies source files about mamute

[csokol]

To package the application we are using the script in
scripts/mvn-package.sh, which copies the build files into a temp dir. This
is a simple solution but I think that we should have a more elegant
solution to fix this.

Chico Sokol

On Wed, Sep 24, 2014 at 1:18 AM, monitorjbl [email protected]
wrote:

Not sure if this is intended or not, but Grunt modifies the actual source
files when it runs in the Maven build. I think this should only happen in
the target directory.

—
Reply to this email directly or view it on GitHub
#74.

[monitorjbl]

Is that a new thing? I tried building the latest from master last night and I saw all of the Javascript/CSS files being modified when I ran git status.

[csokol]

Sorry, I wasn't clear enough. To generate the war you should execute the
script:

$ scripts/mvn-package.sh

If you generate the build directly with maven (mvn package) it will modify
js/css files.

Chico Sokol

On Wed, Sep 24, 2014 at 10:29 AM, monitorjbl [email protected]
wrote:

Is that a new thing? I tried building the latest from master last night
and I saw all of the Javascript/CSS files being modified when I ran git
status.

—
Reply to this email directly or view it on GitHub
#74 (comment).

[monitorjbl]

Ah, I see. Want to leave this issue open for that more elegant solution, or is it alright to close it?

[csokol]

I you can leave it open. It makes sense to find a solution integrated with
maven.

Chico Sokol

On Wed, Sep 24, 2014 at 10:39 AM, monitorjbl [email protected]
wrote:

Ah, I see. Want to leave this issue open for that more elegant solution,
or is it alright to close it?

—
Reply to this email directly or view it on GitHub
#74 (comment).

[leocwolter]

I think we could stop running the grunt task at package phase and execute it explicitly at mvn-package.sh, it should be enough.

[leocwolter]

Oh, sorry, we can't, this would break previous versions of mamute if they want to update it

[csokol]

I prefer to find a way to customize mvn package and remove the shell
script. It's more natural since our project is based on maven.

Chico Sokol

On Wed, Sep 24, 2014 at 11:47 AM, Leonardo Cesar Wolter <
[email protected]> wrote:

Oh, sorry, we can't, this would break previous versions of mamute if they
want to update it

—
Reply to this email directly or view it on GitHub
#74 (comment).

[leocwolter]

Yes, but we can't stop running the grunt task on package since the old update-mamute.sh script will call mvn package. If we stop running it will generate an invalid instance of mamute(without any assets)

[monitorjbl]

I believe one of the Maven lifecycle events puts all the resources in target. Couldn't you direct Grunt to run against that directory instead?

[csokol]

My idea is to run grunt during the package phase, and grunt should be
configured to touch the files in the target/mamute-version/ directory only
(this was how it was done with ant)

Chico Sokol

Yes, but we can't stop running the grunt task on package since the old
update-mamute.sh script will call mvn package. If we stop running it will
generate an invalid instance of mamute(without any assets)

—
Reply to this email directly or view it on GitHub
#74 (comment).

[leocwolter]

Yes, it would be great. I'm guessing the plugin supports this: https://github.com/allegro/grunt-maven-plugin#environment

[leocwolter]

@monitorjbl @csokol any news about that?

[xuanit]

Hi Mamute Team,

In order to build the site by "mvn install", I did modify the pom.xml as below.

• Copy all files from webapp to a tmp folder before the grunt command executed by using "maven-antrun-plugin".
• Modify the configurations of Grunt to update the files in the tmp folder.
• Modify maven-war-plugin to package files from tmp folder instead of webapp.

Regards,
Xuan