Coder Social home page Coder Social logo

Fix Rendering Issues about cabal-cli HOT 4 CLOSED

cabal-club avatar cabal-club commented on May 27, 2024
Fix Rendering Issues

from cabal-cli.

Comments (4)

cblgh avatar cblgh commented on May 27, 2024 2

@julianpistorius wow i can't believe i missed this excellent screencast, thank you so much!

i think you might be right in the problems stemming from text areas becoming outsized. it looks like this causes issues in diffy

scat has had problems with this as well, but fixed them through limiting text output stripedpajamas/scat#3

from cabal-cli.

cblgh avatar cblgh commented on May 27, 2024 1

closed!!!

commits:

  1. emojis caused rendering problems
  2. fullwidth characters (CJK, chinese japanese korean) caused rendering problems
    to solve 1: use a grapheme-splitting library to correctly chunk messages into their constituents (individual characters, emojis + COMBINED emojis like purple hearts or people kissing)
    use the split string to filter out characters in the upper astral planes of unicode (i.e. only keep characters in the basic plane, or with a code point below 65536)
    to solve 2: patch txt-blit to account for fullwidth characters, see hackergrrl/txt-blit#3

from cabal-cli.

hackergrrl avatar hackergrrl commented on May 27, 2024

This would be so wonderful @cblgh ❤️ 🎉 🌟

from cabal-cli.

julianpistorius avatar julianpistorius commented on May 27, 2024

I think I've started disentangling things.

I also see issue #10, and I suspect this warning might be causing a rendering issues for me as soon as the app starts - but only on Node 10.3.0.

When I use Node 9.11.1 I don't see this warning, and I also don't see the rendering issue when the app starts. But I do see the same rendering issue later on if I type long sentences with many words.

Fundamentally what I think triggers the rendering issue is when the input in the text entry area at the bottom of the screen grows beyond a certain size. Issue #10 just happens to trigger the rendering issue earlier.

Test environment

Operating System: Mac OS X 10.11.6 (El Capitan)
Cabal version: 2.3.1
Git hash: 49ab4b4276a4360e3dc5a98ac44e9df1f31f5ef8
Bash: GNU bash, version 4.4.19(1)-release (x86_64-apple-darwin15.6.0)
Readline: stable 7.0.3 (bottled), devel 8.0-alpha [keg-only]

Screencast

asciicast

Screenshots

Screenshot: Node 10, with warning and rendering issue

node_10_warning_and_rendering_issue

Screenshot: Node 9, no warning, but still rendering issue

node_9_no_warning_but_still_rendering_issue

from cabal-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.