Comments (4)
The few commands I tested are case insensitive in their names (/lagstats, /LAGSTATS, and /lagSTATS all work the same), so I assume this refer to the handling of specific help topics. For example, /help rules is different from /help RULES.
It would be trivial to use TextUtils::compare_nocase()
to make help topics be case insensitive. I'd like to get input about the impact on server configurations before deciding whether to make such a change.
from bzflag.
I'd be in favor of having them be case insensitive. I personally don't have any help topics that are different due to case. Is there a use case for having /help rules
be different from /help Rules
?
from bzflag.
Case-insensitive help file names sound fine to me, as long as both ends of it (the help file initialization and the command parser) handle it the same way.
from bzflag.
@macsforme This may be what you meant, but just to be clear, the issue is about the help message name, not the help message filename. The -helpmsg command line option specifies a filename (example: ../help/rules.txt) and a name (example: rules). The name is used to access the help message via the /help command, which is what is being compared case sensitively.
Fixing this should only require a minor change to src/bzfs/commands.cxx, making the comparison in sendHelpTopic use the TextUtils method that @JMakey mentioned. There should not be a need to modify the TextChunkerManager for this.
from bzflag.
Related Issues (20)
- Skewed textures HOT 1
- Question(s) regarding: bz_triggerFlagCapture() HOT 1
- cURL Deprecation Warnings
- Windows Defender SmartScreen flags BZFlag as unrecognized app HOT 1
- OSX zoom feature freezes computer.
- Confine mouse issue between fullscreen modes on macOS HOT 1
- Physics breaks at high altitude at high framerate
- Fullscreen toggle issue on macOS with later SDL versions
- [BZFS API] Unable to get shotID compare to shotGUID from server shots HOT 1
- Tank skin does not change for Rogue
- [Bug] flagid in bz_ePlayerDieEvent may be incorrect HOT 3
- High jitter reported
- BZFS World Construction calls member functions on NULL object
- Potential buffer overflow in RecordCommand() function in bzfs module HOT 1
- Collision between tank and base is wrong
- Features Add some customization HOT 1
- Skewed Textures HOT 3
- Infinite loop if window is resized to be tall and thin
- Crash on 2.4.27 corrupted size vs. prev_size HOT 1
- Unable to paste password into password field
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bzflag.