Coder Social home page Coder Social logo

Comments (4)

JMakey avatar JMakey commented on May 29, 2024

The few commands I tested are case insensitive in their names (/lagstats, /LAGSTATS, and /lagSTATS all work the same), so I assume this refer to the handling of specific help topics. For example, /help rules is different from /help RULES.

It would be trivial to use TextUtils::compare_nocase() to make help topics be case insensitive. I'd like to get input about the impact on server configurations before deciding whether to make such a change.

from bzflag.

allejo avatar allejo commented on May 29, 2024

I'd be in favor of having them be case insensitive. I personally don't have any help topics that are different due to case. Is there a use case for having /help rules be different from /help Rules?

from bzflag.

macsforme avatar macsforme commented on May 29, 2024

Case-insensitive help file names sound fine to me, as long as both ends of it (the help file initialization and the command parser) handle it the same way.

from bzflag.

blast007 avatar blast007 commented on May 29, 2024

@macsforme This may be what you meant, but just to be clear, the issue is about the help message name, not the help message filename. The -helpmsg command line option specifies a filename (example: ../help/rules.txt) and a name (example: rules). The name is used to access the help message via the /help command, which is what is being compared case sensitively.

Fixing this should only require a minor change to src/bzfs/commands.cxx, making the comparison in sendHelpTopic use the TextUtils method that @JMakey mentioned. There should not be a need to modify the TextChunkerManager for this.

from bzflag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.