Coder Social home page Coder Social logo

Comments (5)

zh-jq avatar zh-jq commented on June 1, 2024 1

If there's a concern about resolving multiple ips, perhaps we could add a check to count the number of ips resolved and return an error if it's more than one?

A warning message is needed to tell the users that the domain support is only restricted to one IP address and no dynamic update will be available.

The UpstreamAddr type can be used for proper domain support. And we should resolve the domain just before we try to connect to the peer.

We may also use the resolved IP addresses to do load balancing, but this should be decided case by case. For the udpdump case, this will cause problem if we send FTP control connection and data connection to different peers.

from g3.

mspublic avatar mspublic commented on June 1, 2024

Thanks @jeffreydwalter. I think this would be useful for more than just docker - many production environments use hostnames not IPs even without docker.

from g3.

zh-jq-b avatar zh-jq-b commented on June 1, 2024

Is it possible to use environment variables? You can set the value to $SOME _RESOLVED_ADDR to read from env var SOME_RESOLVED_ADDR.

Domains can be dynamically updated and may resolve to many IP addresses, it's not easy to add proper support.

from g3.

mspublic avatar mspublic commented on June 1, 2024

In my opinion this patch doesn’t prevent someone from doing that or using an IP. It just gives the option of using the domain instead.

Some environments (such as ones using envoy/istio) need the domain info to do routing. Without it they can’t find the target.

from g3.

jeffreydwalter avatar jeffreydwalter commented on June 1, 2024

If there's a concern about resolving multiple ips, perhaps we could add a check to count the number of ips resolved and return an error if it's more than one?

from g3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.