Comments (5)
If there's a concern about resolving multiple ips, perhaps we could add a check to count the number of ips resolved and return an error if it's more than one?
A warning message is needed to tell the users that the domain support is only restricted to one IP address and no dynamic update will be available.
The UpstreamAddr
type can be used for proper domain support. And we should resolve the domain just before we try to connect to the peer.
We may also use the resolved IP addresses to do load balancing, but this should be decided case by case. For the udpdump case, this will cause problem if we send FTP control connection and data connection to different peers.
from g3.
Thanks @jeffreydwalter. I think this would be useful for more than just docker - many production environments use hostnames not IPs even without docker.
from g3.
Is it possible to use environment variables? You can set the value to $SOME _RESOLVED_ADDR
to read from env var SOME_RESOLVED_ADDR
.
Domains can be dynamically updated and may resolve to many IP addresses, it's not easy to add proper support.
from g3.
In my opinion this patch doesn’t prevent someone from doing that or using an IP. It just gives the option of using the domain instead.
Some environments (such as ones using envoy/istio) need the domain info to do routing. Without it they can’t find the target.
from g3.
If there's a concern about resolving multiple ips, perhaps we could add a check to count the number of ips resolved and return an error if it's more than one?
from g3.
Related Issues (20)
- Evaluate Profile-Guided Optimization (PGO) and LLVM BOLT HOT 1
- 后续可以支持PPV1 吗 HOT 1
- 请教完整的tlcp代理示例 HOT 3
- g3proxy: Ability to change ClientHello sent to upstream server HOT 18
- Track upstream features that we want to use
- Docker container support HOT 2
- 配置文件存放路径文档不对 HOT 2
- Documentation Improvements HOT 3
- Issues with SSL interception HOT 8
- ICAP issues HOT 3
- Bump g3fcgen version to v0.6.3 release HOT 1
- Feature Request: Full remote certificate inspection and duplication for TLS MITM HOT 2
- Issues with TLS Stream Dump HOT 3
- g3-io-ext 编译出错 HOT 2
- Ability to disable HTTP2 connections? HOT 3
- How do I add an upstream certificate for proxy chaining? HOT 2
- G3 panics in src/g3proxy/src/inspect/stream/object.rs HOT 1
- Certain sites fail to load if browser is using HTTP1 via G3proxy HOT 4
- G3proxy is unable to connect to g3fcgen on MacOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from g3.