Comments (2)
@6a Do you have any thoughts here?
from wasmtime.
@bnjbvr's suggestion does feel more "rusty" (and cleaner), but two details bother me with it:
- Now we have to basically return a
Result<Vec, Vec>
, which is not as lightweight as I intended. - If we have multiple non-fatal errors from say, five function calls in a row, that means we have to merge five different
Vec
s, which is likely not as efficient as what we do right now.
We would also have to take care of merging each vector, which would lead to this kind of code:
let a = verify_foo()?;
let b = verify_bar()?;
a.extend(&mut b);
let c = verify_baz()?;
a.extend(&mut c);
IIRC I also wanted to get rid of the T
, but for some reason we kept it. If we don't see a problem with the deletion, then I'm fine with removing it.
from wasmtime.
Related Issues (20)
- CI: wasi-* crates tests failed due to the `wmemcheck` feature conflict HOT 3
- Wasmtime support for AWS Graviton HOT 2
- `out of bounds memory access` with over 1032kb of data HOT 5
- `wasi-common/sync` still introduces dependency on Wasmtime, but why? HOT 4
- Should a "pointer type" be added to Cranelift? HOT 14
- `wasi_snapshot_preview1::fd_write` has not been defined HOT 4
- Make define_unknown_imports_as_traps available in CLI
- Handling pointer provenance in Pulley HOT 2
- unresolved import `wasmtime_asm_macros::asm_sym` HOT 3
- ERROR:undefined reference to `wasmtime_val_copy HOT 3
- Failed to run the wasm32-wasip2 code HOT 5
- Cranelift: "constant immediate is out of bounds" HOT 2
- Support of profile for wasm component HOT 5
- Cranelift: implement path-sensitive constant propagation HOT 6
- Access flags are lost when using `openat` from `wasi-libc` HOT 1
- Remove special case for InputStream::File ? HOT 13
- Idea: put VM data structures in arena with relative pointers for security and strict provenance HOT 3
- add `uninlined_format_args`
- large enums slow down compilation HOT 4
- s390x: no rule matched for term vec_elt_rev HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wasmtime.