Use `prettyplease` instead of `rustfmt` for the source code generated by `cargo component new --target` about cargo-component

[sunfishcode]

@DougAnderson444 I encountered similar errors and submitted #247 to fix them.

[peterhuene]

I'll release a patch release shortly, but in the meantime I've posted a workaround to disable formatting of the bindings to the release notes of 0.9.0.

[peterhuene]

After implementing this, I discovered that prettyplease doesn't preserve whitespace (specifically new lines between items), which makes sense since it's going off of a syn::File.

That's relatively unimportant for something like bindings.rs, but more important for lib.rs.

Given that the code generated from the --target option is relatively uncomplicated, I think we can keep using rustfmt for now.

[DougAnderson444]

@peterhuene I am trying to migrate to v0.9.0 but I keep getting rustfmt errors on the libraries I am converting:

error[internal]: left behind trailing whitespace
   --> <stdin>:575:575:1
    |
575 |                         
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    |

error[internal]: left behind trailing whitespace
   --> <stdin>:599:599:1
    |
599 |                     
    | ^^^^^^^^^^^^^^^^^^^^
    |

error[internal]: left behind trailing whitespace
    --> <stdin>:1188:1188:1
     |
1188 |                     
     | ^^^^^^^^^^^^^^^^^^^^
     |

Full Log

left behind trailing whitespace
   --> <stdin>:575:575:1
    |
575 |                         
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    |

error[internal]: left behind trailing whitespace
   --> <stdin>:599:599:1
    |
599 |                     
    | ^^^^^^^^^^^^^^^^^^^^
    |

error[internal]: left behind trailing whitespace
    --> <stdin>:1188:1188:1
     |
1188 |                     
     | ^^^^^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1194:1194:1
     |
1194 |                 
     | ^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1200:1200:1
     |
1200 |             
     | ^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1240:1240:1
     |
1240 |                     
     | ^^^^^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1246:1246:1
     |
1246 |                 
     | ^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1263:1263:1
     |
1263 |                 
     | ^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1269:1269:1
     |
1269 |             
     | ^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1294:1294:1
     |
1294 |                 
     | ^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1300:1300:1
     |
1300 |             
     | ^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1312:1312:1
     |
1312 |             
     | ^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1892:1892:1
     |
1892 |                   
     | ^^^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1898:1898:1
     |
1898 |               
     | ^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:1904:1904:1
     |
1904 |           
     | ^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:2510:2510:1
     |
2510 |                 
     | ^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:2516:2516:1
     |
2516 |             
     | ^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:2522:2522:1
     |
2522 |         
     | ^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:3163:3163:1
     |
3163 |                   
     | ^^^^^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:3169:3169:1
     |
3169 |               
     | ^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:3175:3175:1
     |
3175 |           
     | ^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:3701:3701:1
     |
3701 |               
     | ^^^^^^^^^^^^^^
     |

error[internal]: left behind trailing whitespace
    --> <stdin>:3733:3733:1
     |
3733 |         
     | ^^^^^^^^
     |

blocking the migration.

This was the only relevant issue I found, but it doesn't look like it was implemented, was it? If not, any idea where this fmt issue is originating?

[DougAnderson444]

@sunfishcode so glad to not be alone! So does that mean we simply await a release patch then?

[peterhuene]

0.9.1 has now been released.