Comments (6)
The problem is that cargo component new
currently runs cargo add
for the wit-bindgen
dependency, and doing so with a workspace.dependencies
entry causes a conflict due to --no-default-features
being passed to cargo add
(it can't be specified on the package dependency even if they're the same value, unfortunately).
To fix this, cargo component new
will need to detect that a compatible workspace dependency already exists and use that instead.
To work around this, you'll need to temporarily remove the workspace dep, add the project, add the workspace dep back, and then convert the package dep to use the workspace one.
Also note that the current release of cargo-component
isn't fully compatible with wit-bindgen
0.19.x; you may run into build errors, especially if you're using resources; what's in main
currently works with it, and with #240 merged soon, I will probably cut a release of cargo-component
.
from cargo-component.
Also note that we hope to remove the wit-bindgen
dependency from user projects in the future, with work already done to prevent the kind of breakage that 0.19.x introduced; at a minimum, we might have a dependency on a tiny "canonical exports" crate that can be built without having to muck with features.
from cargo-component.
I verified that with these changes we get the expected behavior of cargo component new
inside of a workspace where the dependencies are already specified:
[dependencies]
bitflags.workspace = true
wit-bindgen-rt.workspace = true
from cargo-component.
@benwis perhaps you're seeing workspace issues too?
from cargo-component.
With bytecodealliance/wit-bindgen#876 and the new wit-bindgen-rt
crate published in the near future, cargo-component
projects will then have only direct dependencies on bitflags
(for the generated bindings) and wit-bindgen-rt
(for exporting required canonical ABI functions).
And since this gets rid of having to specify features on the dependencies, it should help fix this particular issue!
from cargo-component.
@peterhuene you rock!
from cargo-component.
Related Issues (20)
- `cargo component check --workspace` should not generate bindings for workspace members without `[package.metadata.component]` set HOT 2
- `cargo-component` is not acquring a file lock for componentization
- Document the schema of the cargo-component Cargo.toml configuration HOT 3
- Hello world example fails when project name contains underscore HOT 1
- Add a `cargo component serve` subcommand that uses a default runner of `wasmtime serve`
- wit pubilsh --init fails to register the WIT package to wa.dev, while it successfully create a pacakge on the registry HOT 4
- Build fails with 'failed to create a target world for package ...' HOT 2
- Use something like nightly.link or a non-re-published release to avoid excess notifications
- Build error: `error: string size out of bounds (at offset {offset})` HOT 10
- Additional `import`s in generated component HOT 2
- Resource Static Methods Cause Build Failure When Imported HOT 5
- Wit package name/version validated against registry publishes
- Some wasi imports added per default into wit HOT 2
- cargo install cargo-component error HOT 5
- Compile error when installing cargo component HOT 7
- Minimum Supported Rust Version (MSRV)
- Bindings are sometimes incorrectly generated type + `Borrow` suffix vs `&` type HOT 2
- `cargo component add` not producing runnable/usable binaries
- Cargo Component install give error in RPI 4 (ARM CORTEX-A72) HOT 3
- Update to `-S cli` instead of `-S common` for wasmtime commands
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-component.