Coder Social home page Coder Social logo

Comments (6)

tianzhou avatar tianzhou commented on May 14, 2024

We need to address it in both frontend and backend to whitelist EXPLAIN. @boojack PTAL

from bytebase.

xiaoluoboding avatar xiaoluoboding commented on May 14, 2024

@tianzhou @boojack maybe we do not need to validate the SQL statement is correct or not. pass the statement to the back-end. At the front-end, we only validate the query is a SELECT statement or not.

from bytebase.

tianzhou avatar tianzhou commented on May 14, 2024

@xiaoluoboding

For frontend, I think do a simple validation to check whether it's SELECT or EXPLAIN SELECT is sufficient.

from bytebase.

boojack avatar boojack commented on May 14, 2024

@xiaoluoboding @tianzhou This failure is because of the frontend package node-sql-parser will throw an SyntaxError with statement explain select * from abc which is correct. And I think maybe using the simple regex is more efficient than node-sql-parser in this situation.

from bytebase.

xiaoluoboding avatar xiaoluoboding commented on May 14, 2024

@boojack just remove isValidStatement function, will be fine. I use the noe-sql-parser to parse the SQL statement, in case we want to use the more info of the query. If we really does not need it. We can remove it.

from bytebase.

xiaoluoboding avatar xiaoluoboding commented on May 14, 2024

Already fixed in the latest version v0.12.0

from bytebase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.