Coder Social home page Coder Social logo

Comments (5)

Byron avatar Byron commented on June 16, 2024 1

Thanks for reporting!

It's incredibly hard to do this right and I hope that over time, I get good enough to get everything right. Thus, I am glad it was fixed downstream by avoiding the yanked version in the manifest instead.

Apparently what would have worked is to yank the patch release, but let that be followed up by another patch which reverts to the last known valid state, allowing Cargo to skip the yanked version instead of failing.

However, somehow I feel that when using cargo install, it should be less strict to make installations work in this case. Or in other words, installations could be a different mode of operation than cargo build done by devs locally. CC @weihanglo to share this case and ideas.

Closing the issue, as suggested, with the option of creating a special patch release if more of downstream is reporting such issues.

from gitoxide.

NobodyXu avatar NobodyXu commented on June 16, 2024

gix 0.61.1 is yanked due to breaking compilation error unless gix-transport is upgraded at the same time.

Though I agree that it would be better to update the release, to mark them as "yanked" on github.

from gitoxide.

wadeduvall avatar wadeduvall commented on June 16, 2024

Fixed downstream, you can probably close this.

from gitoxide.

weihanglo avatar weihanglo commented on June 16, 2024

rust-lang/cargo#7169 is the relevant issue.

The installation method on starship.rs website is with the --locked flag, so that yanked version can still be selected. I'd generally suggest following what the author recommends. That being said, I understand the inconvenience 😞.

For yanking a version, I would recommend what has been told in the cargo yank manual:

A common workflow is to yank a crate having already published a semver compatible version, to reduce the probability of preventing dependent crates from compiling.

Not a hard requirement but it would be nicer if we follow that :)

from gitoxide.

Byron avatar Byron commented on June 16, 2024

rust-lang/cargo#7169 is the relevant issue.

Thanks, I am watching that now.

A common workflow is to yank a crate having already published a semver compatible version, to reduce the probability of preventing dependent crates from compiling.

Not a hard requirement but it would be nicer if we follow that :)

That's exactly what I learned the hard way here 🤦‍♂️. Amazing 😅.

from gitoxide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.