question about the difference between notebook version and script version about iqn-and-extensions

[BY571]

Hey, without having had a look back at the code I wouldn't use the notebook version. Usually I use the notebook to test and hack things together. The script version should be the better version. Sry for the confusion, let me know if it works for you! Kind regards, Sebastian --Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 01.03.23, 11:02 schrieb Sheng Xu ***@***.***>: Hello, I'm sorry to disturb you. I want to ask about the difference of "get_action" between notebook version and script version. Specifically, the "get_action" in notebook version is self.forward(inputs, self.K), but in script version (namely in calss IQN in modul.py), it is self.forward(inputs, self.N). And I can not find any use of self.K in agent.py. From my perspective, I think maybe the version in the notebook version is wrong? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Jasonxu1225]

Thank you for your reply!
I think maybe it is better to use K to get_action in the script version, which is corresponding to the paper.

[BY571]

Sure, feel free to change the script based on your needs. If you want you can also do a pr including that change! --Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.Am 01.03.23, 11:12 schrieb Sheng Xu ***@***.***>: Thank you for your reply! I think maybe it is better to use K to get_action in the script version, which is corresponding to the paper. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

[Jasonxu1225]

Thank you for your reply!
I have try to do a pr to fix the error of get_action in script version.
Many thanks again!

[Jasonxu1225]

Sorry, after detailed observation. I find that there is no reflection of

in your code.
So maybe the questions about K and N above do not work. Because there is nothing about K in your code.

[Jasonxu1225]

After specific considerations, I think maybe the notebook version is correct, namely using K to get_action as a sample. And I have try to do a pr to fix the error of get_action in script version, many thanks!