Coder Social home page Coder Social logo

Comments (7)

bvaughn avatar bvaughn commented on May 3, 2024

Interesting request @cissyshi! Let me take a look.

from angular-form-for.

bvaughn avatar bvaughn commented on May 3, 2024

What would the API for this look like? I could imagine a couple of things...

  • I could imagine exposing some kind of is-valid/has-error bindable attribute that you could watch and then update the before/after icon accordingly.
  • Or I could imagine allowing you to specify different icons for error states, more like... before-icon-valid and before-icon-invalid.

I'm thinking the 2nd approach feels a little nicer, but I'd like others to weigh-in.

from angular-form-for.

cissyshi avatar cissyshi commented on May 3, 2024

I think I like the second option better.
I could also see you allowing before-icon accepting two types like ng-class.

before-icon="some-icon"
or
before-icon="{valid: 'some-valid-icon', invalid: 'some-invalid-icon'}"

from angular-form-for.

bvaughn avatar bvaughn commented on May 3, 2024

Ah! I like that suggestion.

from angular-form-for.

bvaughn avatar bvaughn commented on May 3, 2024

Let's go with this:

<text-field attribute="email"
            icon-after="{pristine: 'fa fa-user', invalid: 'fa fa-times', valid: 'fa fa-check'}">
</text-field>

So you can specify a different icon for pristine, valid, and invalid states. (I think the addition of pristine is important since we don't want to show a check or an x for a field that hasn't been validated yet.)

from angular-form-for.

bvaughn avatar bvaughn commented on May 3, 2024

Please disregard that previous commit. I pushed too soon and discovered a regression while testing.

from angular-form-for.

bvaughn avatar bvaughn commented on May 3, 2024

This feature is available in 1.2.10.

Here is a working demo of the various ways field icons can now be assigned:
http://bvaughn.github.io/angular-form-for/#/demo/dynamic-icons

Thank you for suggesting this enhancement. :)

from angular-form-for.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.