Comments (7)
Interesting request @cissyshi! Let me take a look.
from angular-form-for.
What would the API for this look like? I could imagine a couple of things...
- I could imagine exposing some kind of is-valid/has-error bindable attribute that you could watch and then update the before/after icon accordingly.
- Or I could imagine allowing you to specify different icons for error states, more like... before-icon-valid and before-icon-invalid.
I'm thinking the 2nd approach feels a little nicer, but I'd like others to weigh-in.
from angular-form-for.
I think I like the second option better.
I could also see you allowing before-icon accepting two types like ng-class.
before-icon="some-icon"
or
before-icon="{valid: 'some-valid-icon', invalid: 'some-invalid-icon'}"
from angular-form-for.
Ah! I like that suggestion.
from angular-form-for.
Let's go with this:
<text-field attribute="email"
icon-after="{pristine: 'fa fa-user', invalid: 'fa fa-times', valid: 'fa fa-check'}">
</text-field>
So you can specify a different icon for pristine, valid, and invalid states. (I think the addition of pristine is important since we don't want to show a check or an x for a field that hasn't been validated yet.)
from angular-form-for.
Please disregard that previous commit. I pushed too soon and discovered a regression while testing.
from angular-form-for.
This feature is available in 1.2.10.
Here is a working demo of the various ways field icons can now be assigned:
http://bvaughn.github.io/angular-form-for/#/demo/dynamic-icons
Thank you for suggesting this enhancement. :)
from angular-form-for.
Related Issues (20)
- Can i validate HTML or other controls using Form-for HOT 21
- Form is submitted when required checkboxes are not checked HOT 8
- Feature request: never validate not-required blank/empty/unchecked inputs HOT 4
- text-field should support input filters HOT 9
- No option to add multiple custom rules to the same field HOT 4
- Checkbox Fix Release HOT 1
- Problem with latest release HOT 9
- Formatting - Select-field HOT 2
- Enable number fields HOT 6
- checkboxField change event does not fire HOT 1
- increment validation HOT 4
- Minimum/maximum rule doesn't work when number is zero HOT 9
- SelectField auto selects the last option initially HOT 6
- Plans for Angular 2? HOT 2
- Support for asynchronous schemas HOT 2
- JSON Schema support HOT 1
- Add support for latest angular-material version HOT 3
- TypeError: Cannot read property 'unwatchers' of undefined HOT 4
- The homepage is dead HOT 1
- Dynamically change validationRules depending on submit action
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-form-for.