Help with a session based token REST API about siesta

[pcantrell]

Making this circuit work as you describe, where it retries automatically and you never see the auth failure, isn't really workable with the Siesta API as it stands.

You can do something close to what you want, if:

1. you’re willing to see the auth error first and then see the refreshed data, and
2. you only want to retry load requests (not POST etc).

Here’s a sketch:

configure {
  $0.config.beforeStartingRequest { resource, request in
    request.onFailure { error in
      if isAuthError(error) {
        doAuthorization() {
          resource.loadIfNeeded()
        }
      }
    }
  }
}

That would clearly need cleaning up and building out. Hopefully it helps.

[pcantrell]

(And I should clarify: isAuthError() and doAuthorization() are hypotherical methods that you would write, and doAuthorization() calls the given closure on success.)

[vdka]

It would be nice to be able to do something like this:

public static func configureMe() {
  service.configure("/me") {
    $0.config.beforeStartingRequest { (resource, request) in
      guard API.isAuthed else {
        switch API.refreshToken {
        case let refreshToken?:
          request.pause() // Stop the request from going out until we are possibly authed.
          API.login(refreshToken: refreshToken).onCompletion { response in
            guard case .Success = response else {
              request.cancel(API.Error.requiresAuth)
              return
            }
            request.resume() // We are now authed and the request may proceed.
          }
        case nil:
          request.cancel(API.Error.requiresAuth)
        }
      }
    }
  }
}

What are your thoughts on a system like this?

[pcantrell]

Auto-reuath and auto-refresh would certainly have widespread appeal. @vdka, I could imagine something along those lines. Instead of request.pause(), I’d first investigate some framework-provided mechanism for letting beforeStartingRequest replace the request wholesale.

[jordanpwood]

I'm doing some initial evaluation of Siesta to handle an API with this exact issue. @vdka, can I ask, what approach did you end up with?

[vdka]

I haven't tackled the issue just yet @jordanpwood but I will in the next couple days, then report back.

[vdka]

The following should work, it doesn't do pre-auth for individual requests but it definitely could be made to. You will need some method of finding the expiration time of your tokens for this method (we are using a JWT which encodes expiration time)

final class API {

  static var service = Service()

  // ...

  static func login(username username: String, password: String) -> Request {

    let request = service.resource(.Auth)
      .request(.POST, json: ["grant_type": "password", "username": username, "password": password, "application_id": clientId])
      .onSuccess { entity in
        let json = entity.json

        guard let token = json["token"].string else {
          fatalError() // handle this better
        }

        guard let refreshToken = json["refresh_token"].string else {
          fatalError() // handle this better
        }

        API.token = token
        API.refreshToken = refreshToken
    }

    return request
  }

  static func login(refreshToken refreshToken: String) -> Request {

    let request = service.resource(.Auth)
      .request(.POST, json: ["grant_type": "refresh_token", "refresh_token": refreshToken, "application_id": clientId])
      .onSuccess { entity in
        let json = entity.json
        guard let token = json["token"].string else {
          fatalError()
        }

        guard let refreshToken = json["refresh_token"].string else {
          fatalError()
        }

        API.token = token
        API.refreshToken = refreshToken
    }

    return request
  }

  public static var token: String? {
    didSet {
      service.invalidateConfiguration()
      service.wipeResources()

      guard let token = token else { return }

      let jwt = try? JWTDecode.decode(token)

      tokenExpiry = jwt?.expiresAt
    }
  }

  public private(set) static var tokenExpiry: NSDate? {
    didSet {
      guard let tokenExpiry = tokenExpiry else { return }

      let timeToExpire = abs(tokenExpiry.timeIntervalSinceDate(NSDate()))

      // Somewhat before the expiration happens
      let timeToRefresh = NSDate(timeInterval: timeToExpire * 0.9, sinceDate: NSDate())

      log.info("Token refresh scheduled for \(timeToRefresh.descriptionWithLocale(NSLocale.currentLocale()))")

      NSTimer.after(timeToRefresh.timeIntervalSinceNow) {

        log.info("attempting auto token refresh")

        guard let refreshToken = API.refreshToken else { 
          log.warning("No refresh token set. Cannot auto-refresh") 
          return
        }

        API.login(refreshToken: refreshToken)
          .onSuccess { _ in log.info("Token refresh successful!") }
          .onFailure { log.error("Token refresh failed with \($0)") }
      }
    }
  }
}

[pcantrell]

I think #98 resolved this. If it didn’t, feel free to reopen.