Coder Social home page Coder Social logo

Comments (6)

igostavro avatar igostavro commented on May 16, 2024

whoever starts on this, just a tip:

I pulled from git and started my own local pod spec.

Had to make the following changes:

#s.resources = "Source/**/*.xib" <<-- remove xibs

  s.subspec "Core" do |s|
    s.source_files = "Source/**/*.swift" #<<-- only copy swift files as source (WAS pulling xibs)
  end

The xib in the project is an iOS xib that prevents TVOS from compiling. Once I excluded it from the pod everything seemed to compile just fine. Testing now.

from siesta.

igostavro avatar igostavro commented on May 16, 2024

As a followup:

maybe ResourceStatusOverlay.xib (and maybe related code) should be moved into a subspec called ResourceStatusOverlayIOS

from siesta.

victorcotap avatar victorcotap commented on May 16, 2024

It would be very beneficial if it could work on watchOs as well. Being able to build one api client for all platforms would be a tremendous improvement
Also splitting UI and Core code might help the process as @igostavro suggested

EDIT: Actually WatchKit includes way of getting data through the iOS app so it's ok if it's dismissed for now. tvOS would be amazing to get tho. Can we split Siesta and SiestaUI ?

from siesta.

pcantrell avatar pcantrell commented on May 16, 2024

Actually WatchKit includes way of getting data through the iOS app so it's ok if it's dismissed for now.

That was my understanding, but…

It would be very beneficial if it could work on watchOs as well.

I’m all for it if anyone finds a need for it.

tvOS would be amazing to get tho

I’d welcome a pull request.

Can we split Siesta and SiestaUI ?

Already done. Isolating UIKit code was done by @onekiloparsec for the macOS target, and I already split SiestaUI for SwiftPM support. Siesta & SiestaUI are now two separate subdirectories under Source, separate targets in the Xcode project, separate modules if you build with SwiftPM or Carthage, and separate subspecs if you’re using Cocoapods.

I’m only aware of two spots in the core Siesta module that require platform-specific attention: the type of parsed images, and the name of the low memory notification. Both should be easy to resolve. Search Source/Siesta/ for the two occurrences of #if.

from siesta.

pcantrell avatar pcantrell commented on May 16, 2024

Looks like maybe @tritt was working on tvOS support?

from siesta.

pcantrell avatar pcantrell commented on May 16, 2024

#187 added a tvOS target. Specs don’t run on tvOS because of Nocilla, but that seems solvable.

I'd like to hear from users about any success / troubles in actual apps before declaring this supported. (See checklist at the top of the issue.)

from siesta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.