Coder Social home page Coder Social logo

Comments (5)

BurntSushi avatar BurntSushi commented on July 28, 2024

I am hesitant to adopt an entity-attribute-value pattern in the schema, particularly when a reasonable solution is to just add another column for a second OT and hope that triple-OT never happens.

Actually, I don't think that's even possible because of the GSIS source data. Last year, double-OT actually happened in the DEN/BAL game. Here's the JSON. You'll note that only 5 quarters are reported, so that the first and second overtime periods aren't actually distinguished.

from nfldb.

BurntSushi avatar BurntSushi commented on July 28, 2024

Note though that quarters are distinguished in the play (and drive?) data, so that the game phase enumeration accounts for double overtimes.

from nfldb.

ochawkeye avatar ochawkeye commented on July 28, 2024

@BurntSushi

You'll note that only 5 quarters are reported, so that the first and second overtime periods aren't actually distinguished.

They actually are distinguished in the JSON data:

{"sp":0,"qtr":5,"down":0,"time":"","yrdln":"","ydstogo":0,"ydsnet":11,"posteam":"","desc":"END QUARTER 5","note":null,"players":{}}
{"sp":0,"qtr":6,"down":1,"time":"15:00","yrdln":"DEN 34","ydstogo":10,"ydsnet":13,"posteam":"BAL","desc":"(15:00) R.Rice up the middle to DEN 32 for 2 yards (D.Williams).","note":null,"players":...

notice "qtr":5 vs. "qtr":6. But I think the fact remains that there is precedent for such a situation and nothing broke.

from nfldb.

BurntSushi avatar BurntSushi commented on July 28, 2024

Yeah, that's what I meant by saying quarters are distinguished in play (and maybe drive) data.

This issue is about getting accurate quarter-by-quarter scoring for a game. The JSON data provides Q1-Q5 scores where Q5 apparently encompasses all OT periods. These correspond to the {home,away}_score_q[1-5] fields in the game table. This is in contrast to play data, where OT periods are distinguished.

Therefore, the only way to actually get correct scores accounting for more than one OT is to compute the scores from play data. Which can be inaccurate.

from nfldb.

BurntSushi avatar BurntSushi commented on July 28, 2024

Issue #6 should hopefully resolve this somewhat. Otherwise, we're at the mercy of the source JSON data.

from nfldb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.