Comments (7)
It's an interesting feature request, there's a lot of problems in the details, however. What would you propose as to the format of the output diff?
from buf.
thanks for getting back to me!
At first thought, can we simply use unified diff format (https://www.gnu.org/software/diffutils/manual/html_node/Unified-Format.html), on top of that, color-syntax and other tools can be built as well.
from buf.
Can you provide an example?
from buf.
How about this
You can also pass in arguments from man diff
.
from buf.
Question: why do you need buf to have a separate command to do this? Ie what do you think buf check diff will do differently than, for example, git diff?
from buf.
good question, I guess I haven't thought this through.
Yes, I think git diff
will do (at least majority) of the work.
but diff
can potentially group and compare fields (of the same tag) together, even if someone has moved the field elsewhere, as it parses the protobuf schema.
However, I think that's a bit too far and uses cases not well-defined: we can always enforce good practice to prevent that.
In that case, I would say don't bother with buf
. Thanks and sorry for the trouble.
from buf.
Sounds good! Let us know if you need anything else here.
from buf.
Related Issues (20)
- Storage bucket with different behaviours
- v1.35.1 is broken HOT 2
- Cannot generate import for googleapis datatype under managed mode. HOT 2
- buf breaking fails for annotated tags with v1.35.0 HOT 4
- Using a plugin that defines some options under `_out` HOT 9
- Add post-processing commands HOT 1
- Buf-breaking fails to clone tag in repo HOT 2
- Buf v1.32.0 and newer walks the entire repository tree when using `--path` HOT 3
- build from source failed HOT 1
- Remove IncludeDocsLink from bufconfig.BufYAMLFile
- inputs paths non base directory HOT 5
- inputs paths is not base directory HOT 1
- Lint: One top level entity (message, enum, service) per file HOT 1
- Should we validate `buf.yaml` configuration when pushing? HOT 1
- Clearing up error messages in `bufconfig`
- HEAD~1 is no longer treated as a valid ref HOT 2
- Dangling _ "github.com/gogo/protobuf/gogoproto" import on `buf generate` for uploaded proto files with gogo fields. HOT 2
- when i use git repo in buf.generate.yaml#inputs, how can i set buf.yaml#modules HOT 5
- pyi output for python grpc HOT 3
- Set default label when pushing to buf registry HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buf.