Review AMPQ client/server node library RHEA about entente

[helio-frota]

Project structure:

• Missing lint.
  eslintrc.json
  lint script
  lint dependencies
  Makefile lint task
• Missing 'files section'.
  files section
• Missing CI support.
  Travis example
• package.json - 'scripts section' using undeclared dependencies:
  "mocha","istanbul,"browserify"
• Missing .gitignore
  ignore node_modules

Documentation:

• Missing information 'how to run/test' for development.
  Contributing guide

Code:

• Some unused variables.
• Function names using underline instead camelCase.
• Using var instead ES6 let and const.
• Some global variables.
• Heavy 'this' usage.
• Mix single and double quotes.
• Magic numbers.
• Missing ';' sometimes.

Style:

• {} on the same line.
• Missing blank lines between functions.
• Long lines
• Spaces

Dev cycle:

• Not able to run the tests with 'npm run test'.

[lance]

Looks good @helio-frota. Thanks!

I've updated the GUIDELINES.md document to address some of your points in the 'Code' and 'Style' sections here. https://github.com/bucharest-gold/entente/blob/master/GUIDELINES.md#some-things-linting-will-catch

@grs Helio has looked through your code and found a number of issues related to our "standard" recommendations for node projects. Have a look here, and we'd be happy to discuss with you.

Thanks!

[helio-frota]

'Some things linting will catch'
true !
@lance 👍

[grs]

Thanks! I'll start going through these soon (I'm on PTO from 21st for a bit, so will likely be when I get back).

[lance]

This looks like it can be closed. Or is there more that needs to be done here?

[balunasj]

Yeah, I think this can be closed. @grs if you would like more help or reviews just open/re-open an issue and ping us on the mailing list!