Perceived Duplicates (Multiple controller instances) about angular-socket-io

[btford]

Please provide a reproduction via jsbin, plnkr.co, or jsfiddle.

[johnstonmatt]

I don't really know how to set up a full stack app in plunkr, could I somehow privately send you a link to my app on heroku?

[johnstonmatt]

also after looking at the src, i tried socket.once, and it also gets fired twice, but the server is logging one output

[btford]

do you not have unit tests for this app?

[johnstonmatt]

I have a few for the client, but I hadnt made any backend mocks because I just moved to socket. Doing that with an http mock seemed a little much at this early stage of dev. I will do that in the coming days(maybe hours). On the main page it says the only API addition was .forward, I havent used that yet, are there other optimizations? Would I have any trouble updating things like ng-repeats without it? If that is really the only thing, and its not critical to updating the scope I might just revert to vanilla socket.io.
-edit-
On a related note maybe just using socket.forward instead of socket.on would fix my problems I'll try that too.
-edit2-
still duplicates for socket.forward
-edit3-
vanilla socket doesn't dupe but its way slower so I'm still looking for a fix

[btford]

I suspect you're accidentally registering listeners twice. there's nothing in my wrapper that i can think of that would cause this behavior.

[johnstonmatt]

On principle given your experience I think its unlikely that you are wrong, but in practice ive used my IDE and literally searched through the whole project. It also happens for every event, which would suggest its not a problem with duplicate listeners.

[btford]

I'm happy to take a look, but I can't do much without some kind of minimal reproduction. :/

[johnstonmatt]

thanks for your support, it was a coincidence the dupes stopped with just socket.io. I did have mulitple listeners but instead of having two event listeners I actually had two server listeners, which is why it didnt turn up when i searched for socket.

[johnstonmatt]

I was quick to say I fixed it, the problem exists both with and without your module, if I run my app in chrome, but there are not duplicates in firefox

[btford]

the problem exists both with and without your module

sounds like it's either a problem in your code or in socket.io code.

[johnstonmatt]

I had duplicated my controller definition in ui-router, I defined the controller once in the header and once in the footer. Thank you for the support once again, it was definitely a silly mistake, but I wish it hadn't gone unnoticed for so long. Because having multiple controller instances is a feature it is probably difficult to catch this human error.