Coder Social home page Coder Social logo

Comments (2)

spike014 avatar spike014 commented on May 27, 2024

context.Cause(ctx) and WithCancelCause is new after Go1.20.

I think the issue should return to :

Should here return ctx.Err() or the error warp with ctx.Err() when ctx.Done() ?

The ctx may with timeout setting.
I think here may let user know why he/she didn't get the lock when the ctx's deadline passes or canceled by someone.
Then the error can be deal with the way like this:

if err == context.DeadlineExceeded {
    log.Println("context timeout error", err)
    // or do something else
    // Timeout~
} else if err == context.Canceled {
    // Oh! Somebody cancaled this context. That is NOT the error from `bsm/redislock`.
}

from redislock.

dim avatar dim commented on May 27, 2024

Will continue in #64, thanks for pointing this out

from redislock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.