Coder Social home page Coder Social logo

Comments (7)

es128 avatar es128 commented on June 15, 2024

Thanks for identifying the issue and a fix. Please do send a PR. Starting with a failing test would be preferable.

from sass-brunch.

ricardobanegas avatar ricardobanegas commented on June 15, 2024

I still get the pipeline.js problem. Not getting this fix with the latest 1.8.10-version of sass-brunch.

Steps to reproduce:

  • npm install sass-brunch --save-dev
  • sed -n 97,97p node_modules/sass-brunch/index.js

Results in: if(data.css) data = data.css; should be if('css' in data) data = data.css; according to 9ab5df8

sass-brunch version is 1.8.10

npm ls --depth=0 | grep sass-brunch
├── [email protected]

from sass-brunch.

sambonbonne avatar sambonbonne commented on June 15, 2024

According to the commits history (https://github.com/brunch/sass-brunch/commits/master), my fix is not in the 1.8.10, you'll need to wait for a new update ... In fact, there is no fix since mine and the 1.8.10 version.
While waiting for a developer answer or a new version, maybe you should apply my fix manually ?

from sass-brunch.

ricardobanegas avatar ricardobanegas commented on June 15, 2024

Oh snap! Thanks for the info, yes already applied the patch but was hoping it was in the update so that I don't need to do an ugly fix for my team.

For others that have the same problem using npm install sass-brunch, you can use bleeding-edge like this in your package.json (not pretty):

"sass-brunch": "https://github.com/brunch/sass-brunch/tarball/master",

from sass-brunch.

ricardobanegas avatar ricardobanegas commented on June 15, 2024

@paulmillr Have you planned a release of sass-brunch with @smumu fix? Thanks!

from sass-brunch.

es128 avatar es128 commented on June 15, 2024

just published 1.8.11 with the fix

from sass-brunch.

ricardobanegas avatar ricardobanegas commented on June 15, 2024

Great thanks.

from sass-brunch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.