Comments (7)
Thanks for identifying the issue and a fix. Please do send a PR. Starting with a failing test would be preferable.
from sass-brunch.
I still get the pipeline.js problem. Not getting this fix with the latest 1.8.10-version of sass-brunch.
Steps to reproduce:
npm install sass-brunch --save-dev
sed -n 97,97p node_modules/sass-brunch/index.js
Results in: if(data.css) data = data.css;
should be if('css' in data) data = data.css;
according to 9ab5df8
sass-brunch version is 1.8.10
npm ls --depth=0 | grep sass-brunch
├── [email protected]
from sass-brunch.
According to the commits history (https://github.com/brunch/sass-brunch/commits/master), my fix is not in the 1.8.10, you'll need to wait for a new update ... In fact, there is no fix since mine and the 1.8.10 version.
While waiting for a developer answer or a new version, maybe you should apply my fix manually ?
from sass-brunch.
Oh snap! Thanks for the info, yes already applied the patch but was hoping it was in the update so that I don't need to do an ugly fix for my team.
For others that have the same problem using npm install sass-brunch, you can use bleeding-edge like this in your package.json
(not pretty):
"sass-brunch": "https://github.com/brunch/sass-brunch/tarball/master",
from sass-brunch.
@paulmillr Have you planned a release of sass-brunch with @smumu fix? Thanks!
from sass-brunch.
just published 1.8.11 with the fix
from sass-brunch.
Great thanks.
from sass-brunch.
Related Issues (20)
- Provide examples on brunch-config.js HOT 2
- Tag latest changes on master HOT 1
- Sass-brunch is taking too long to compile HOT 10
- Failed postinstall script on Linux-x64-57 ( node-sass dependency needs to be updated) HOT 5
- "BrunchError: Failed to read file" when editing sass file
- dead?
- Change node-sass dependency to peerDependency
- NPM Registry out of date with Github repo
- Can't install HOT 1
- Latest release breaking production HOT 5
- Latest release causes build to stuck HOT 5
- Issue with watching underscore files with 2.10.7 HOT 2
- scss modules / partial (_example.scss) not recompiled during brunch watch process HOT 3
- Partial .scss files are compiled although they were not included in main .scss file HOT 10
- Issue with node 12 HOT 4
- npm install error HOT 6
- please release updated npm package HOT 2
- Source map generation failure on Windows HOT 12
- Source map generation error when deploying to Heroku HOT 5
- Readme refers to unused Sass implementations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sass-brunch.