Semicolons about history.js

[balupton]

This is kind of a duplicate of: #46

This is kind of outside the scope of History.js - the files are compressed with Buildr + UglifyJS which omits the end-of-file semi-colon in the compressed versions of the file. Buildr also supports bundling too, you can change the "buildr" part in the package.json file to:

"buildr": {
    "compress": {
        "js": true,
        "css": false,
        "img": false,
        "html": false
    },
    "check": {
        "js": true,
        "jsOptions": {
            "browser": true,
            "laxbreak": true,
            "boss": true,
            "undef": true,
            "onevar": true,
            "strict": true
        }
    },
    "ignore": {
        "check": [
            "json2.js",
            "amplify.store.js"
        ]
    },
    "bundle": {
        "js": "history.all.js",
        "css": false
    },
    "directories": {
        "out": "./scripts/compressed",
        "src": "./scripts/uncompressed"
    },
    "files": {
        "js": [
            "amplify.store.js",
            "history.adapter.jquery.js",
            "history.js"
        ],
        "css": false,
        "img": false
    }
}

and that will bundle the mentioned js files into a history.all.js file. Or I'd say that in your bundling script, it should be adding semicolons between files.

Though with closure and uglify I've never had an issue bundling. Here is also a php script that I've used to bundle with closure: https://github.com/balupton/balphp/blob/master/lib/Bal/View/Helper/HeadScriptBundler.php#L77

[deleteme]

Related UglifyJS Issue: mishoo/UglifyJS#126 (comment)

Because I am including history js as a git submodule and inlining the minified files, I had to do this in my HAML:

%script
  -# inlining minified libraries
  -# having to insert a few missing semicolons.
  = render :file => 'public/javascripts/lib/history/scripts/compressed/history.adapter.zepto.js'
  \;
  = render :file => 'public/javascripts/lib/history/scripts/compressed/history.js'
  \;
  = render :file => 'public/javascripts/lib/history/scripts/compressed/history.html4.js'
  \;

Google Closure preserves the trailing semicolon for this reason. I am not sure what other minification libraries do.

It would be nice if the minified files were immediately usable, otherwise, why provide them at all?

[balupton]

I've got a question. Does the bundler you're using also minify? If so, just include the uncompressed scripts...

It would be nice if the minified files were immediately usable, otherwise, why provide them at all?

They are individually, which is actually what the majority of people do :/

[deleteme]

I have a rake script that watches my javascript files for changes, runs it through yui's compressor, and then outputs a minified file in a different directory. I could update it to consider the uncompressed history.js javascript, but then I lose the benefit of having a git submodule to manage the library.

[balupton]

... how would it affect git submodules? Both the uncompressed and compressed are in the same git repo...

[Sinetheta]

Yup, still causing pain.

[Angelinsky7]

Yes, still causing pain in 2017...