Samsung Internet data missing from JSON output about browserslist-ga

[rtymchyk]

Looks good @dmfrancisco

[natewoodbridge]

Thank you @dmfrancisco. It's working when I use the npx github:browserslist/browserslist-ga command.

[jamespamplin]

@dmfrancisco interesting, on caniuse.com when I import, Samsung is in the Browsers not included column. Couldn't find the caniuse repo to raise/find the issue there.

[jamespamplin]

Thanks @dmfrancisco, raised the issue: Fyrd/caniuse#4742

[jamespamplin]

@dmfrancisco yep, all working now in caniuse.com - see Fyrd/caniuse#4742

[dmfrancisco]

Thanks for confirming 👍 I'll submit a PR this weekend with the changes

[rtymchyk]

Oh oops, my bad, didn't realize it was not released yet. I will test and get back to you.

[dmfrancisco]

Thank you for opening the issue 👍 That is strange. I checked with a couple of my websites and it also gives me zeros, but it's indeed 0% comparing to the other browsers, so it's hard for me to reproduce. It should be supported and parsed correctly.

[albe]

Can confirm. We have around 5% Samsung Internet users and from that ~50% 7.2, but still the generated browserslist-stat from calling npx browserslist-ga shows:

  "samsung": {
    "4": 0,
    "5": 0,
    "6.2": 0,
    "7.2": 0
  },

PS: If you need help testing, let me know

[jamespamplin]

Also having this issue. We've got 5% Samsung browser usage in the GA web interface.

[dmfrancisco]

Could you please try the following: If you import your Google Analytics data in caniuse.com (by clicking the cog icon and then "From Google Analytics: Import"), does Samsung appear in the "Browsers included" column? This code is based on theirs so I just want to see if the issue happens there too. Thank you 👍

[dmfrancisco]

Thanks @jamespamplin 👍I don't think there's a repo for the website, but people seem to report the issues related to the Google Analytics import in the main caniuse repo. Could you help us by raising the issue there with your data?

[dmfrancisco]

@jamespamplin Thank you 👍Can you confirm that the issue was fixed on caniuse.com? If it's working now, I'll implement the changes as soon as possible 🙂

[rtymchyk]

@dmfrancisco @Nooshu is this fixed with that PR? I am still seeing all 0 for all Samsung Internet browsers, even though GA has a pretty high % on 8.2

[dmfrancisco]

@rtymchyk I think so but I don't have data to test. Could you confirm with the version on master (the NPM package hasn't been updated yet) please?

[natewoodbridge]

This issue stills seems to be happening - I am getting zero results for Samsung, however in GA we have 5% for Samsung Internet 9.2. Using the npx command, so should be on the latest version.

Any ideas would be appreciated.

[dmfrancisco]

@natewoodbridge Are you using the NPM version? I haven't published the patch. Can you try it out with master? Sorry for the inconvenience.

[rtymchyk]

Has this been released yet to NPM?

[davidstosik]

Doesn't seem so, I still get a straight 0% for all Samsung browser versions whereas we have above 5% of users.

Using npx github:browserslist/browserslist-ga fixed it.