3.0.6 upgrade completely broke some old code.. about pbkdf2

[dcousens]

@mkrn can you elaborate why process.version was undefined?
The only other reported case was that they had a very old version of browserify being used.

We have this PR open, but we're not sure how necessary it is yet.

[mkrn]

Suggest peer-dependencies or checking for existence of process.version... not sure what is it for?

[mkrn]

Yes browserify at 7.0.2 just some old deployment broke on re-install of modules..

[dcousens]

@mkrn OK, we'll push that PR through now and publish.

[mkrn]

Thanks a lot, as a fix had to shrinkwrap, then manually edit the version down below and reinstall like that..
Hopefully this wont cause problems for anyone else.)

[dcousens]

Published + [email protected]

[dcousens]

Thanks for reporting the issue @mkrn

[neil-morrison44]

@dcousens the fix in the PR won't fix for other people running old versions of browserify since process isn't included at all
but if if (process.browser) { was something that checked if process existed like
if ((typeof process === "undefined") || process.browser) {
then it'll avoid the issue for other people.
I figure a lot of people don't update their build files once they get them working, vs wanting to stay up to date on crypto components.

[dcousens]

@neil-morrison44 are you able to set up a test for that?

[neil-morrison44]

@dcousens I'm not sure how you'd run the bundle-test against a few versions of Browserify.
If you're looking for prior art the AWS-sdk-js package doesn't trust that there's going to be a process object either:
https://github.com/aws/aws-sdk-js/blob/master/lib/browser_loader.js