Comments (3)
I do have it fixed locally, I'll send a pull request with this change.
from browserhtml.
As of why that was the case:
If you want to stay with in react (like I wanted to for keyboard handling & still not sure that's a best way to go) event handlers will be invoked as long as they occur with in the node into which react renders.
The problem you see is that when you under the location bar which body element get's focused and all the keyboard events occur on it which is why root of react does not handles them. Solution I've used was to make sure that body never becomes document.activeElement
so that react root component will be able to handle keyboard events.
I've also filled a ticket for react here facebook/react#2846
from browserhtml.
Works now.
from browserhtml.
Related Issues (20)
- Display tab history as a trail
- Vertical navigation in overview
- Vertical scroll in overview
- Horizontal navigation in overview HOT 3
- goBack / goForward navigation HOT 1
- Trail forking HOT 4
- Background link loading HOT 4
- Vertical scroll across tabs. HOT 3
- Modal UI HOT 11
- Bring back session restore
- ContentScript for browser.html in WebExtensions manifest file HOT 1
- Autocomplete sometimes makes it impossible to type exact domains HOT 1
- run browser.html with the servo binary? HOT 2
- Windows: Backspace does not work consistently HOT 2
- Close/Minimize/Maximize buttons don't work on OSX
- Header exploration HOT 1
- Pinned Sidebar
- [META] Purpose of BrowserHTML HOT 4
- "electron ." fails HOT 6
- embedding HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from browserhtml.