Comments (2)
As a quick and dirty change, I did the following change which works:
for i in range(0, len(lines)):
line = lines[i]
if line.startswith("ExecStart="):
# If we want to ensure the plugin is enabled
if not toggle:
exec_start = re.sub(" --compat --noplugin=\*", "", line)
else:
exec_start = line + " --compat --noplugin=*"
service = f"[Service]\nExecStart=\n{exec_start}"
out_file_dir = "/run/systemd/system/bluetooth.service.d/"
out_file = out_file_dir + "nxbt.conf"
if toggle:
os.makedirs(out_file_dir, exist_ok=True)
with open(out_file, "w") as f:
f.write(service)
else:
os.remove(out_file)
The first part can be cleaned by simply getting the ExecStart from the file, no loop needed.
from nxbt.
I've accepted your PR to get things rolling with cleaning up the toggle_clean_bluez
function. When I find some time, I'll see about prioritizing further cleanup (eg: removing the for loop).
Thanks again for contributing this 👍
from nxbt.
Related Issues (20)
- Bluetoothctl issue HOT 5
- LS PRESS RS PRESS not working HOT 1
- What distro of linux does this really work on? HOT 1
- Please include a more detailed installation guide for Linux
- Got this working but got issues HOT 1
- Adress already in use HOT 1
- test
- Webapp not working HOT 6
- Script works sometimes
- Other devices show my laptop as Pro Controller after uninstall HOT 1
- How to hold down one button, then pressing another while still holding down the first button? HOT 2
- Ability to hold down one button throughout runtime of NXBT macro HOT 3
- sudo nxbt demo / sudo nxbt test / sudo nxbt webapp not doing anything HOT 3
- How to change keyboard mapping?
- Can't properly install NXBT HOT 8
- Webapp still not working
- VBoxManage not installed when it is installed HOT 1
- vagrant up stops when booting VM on VirtualBox 7.0.10+Ubuntu 22.04
- Installation does not work, needs better install instructions.
- Password prompt for Bluetooth only appearing AFTER timeout reached
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nxbt.