Comments (2)
Distinguishing two classes with tags is absolutely possible, but it requires making sure the tags are coherently applied.
If you look at the definition of Run_Status
, it is defined as being equivalent to two tags (https://github.com/BrickSchema/Brick/blob/master/status.py#L229), and thus it inherits the super class Start_Stop_Status
. This should be better articulated so that each subtree of tags is unique, but it is far from a fundamental issue with the structure. We could probably remedy some of the subclass relationships; the existing hierarchy is carried forward from Brick v1 I believe, which explains the inconsistencies.
Its too bad that the inference/test results are private google drive documents. Can you put them up as Github gists instead so they are easier to work with?
Also, it would be good if we can isolate the specific classes and tags that are causing a mismatch between the expected parent classes and the inferred parent classes
from brick.
I didn't use Gist because the TTL file was too large. The browser hangs. The JSON file turns out to be fine so I edited the link above. (https://gist.github.com/jbkoh/438a58d2cfb250654f2b6e15431a8a55)
I understand the structure itself has no problem with the inconsistency but the human authors are, and the testing framework should help them.
The V1 hierarchy did not assume tags subsumptions and that's why it was fine (of course there should have been obvious bugs anyway.)
I think we have to manually go through the 177 classes before we release the version.
from brick.
Related Issues (20)
- Unify Heat Pump, Chiller PRs
- Import .ttl file to large language model HOT 3
- Equipment Interrelationships using the System class
- Porting the REC ICT Equipment to BRICK
- Missing equipment for physical sensors in water and air systems HOT 1
- Question Refrigerant systems and loops HOT 1
- Optimal Representation of Water Heaters
- Redefining Setpoint Classifications: Target and Threshold HOT 5
- Tests fails on master branch HOT 2
- Right way to model Setpoints HOT 1
- Mapping to other ontologies HOT 3
- Modeling of heating substations HOT 1
- Modeling loops and connections HOT 1
- Questions about the bacnet ontology HOT 4
- Adjacent rooms HOT 2
- Reintroducing the Concepts of Supply/Return Temperature Sensors and Setpoint for the Water Systems HOT 1
- How to model the heatflow of a radiator? HOT 2
- Possible syntax error when using Prefix Declaration for SPARQL Queries HOT 4
- In v1.4 lots of Points as direct subclasses of Thing HOT 4
- Address Brick/REC Collection
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brick.