BigDecimal and BigInteger should not be final classes. about math

[BenMorel]

Did you notice that there is support already for base [2-36] in parse() and toBase()?

You can parse a string in base 16:

$i = BigInteger::parse('123456ABCDEF', 16);
echo $i; // 20016001699311
echo $i->toBase(16); // 123456abcdef

But internally the BigInteger is always in base 10. What are you trying to achieve that you cannot do with the current BigInteger? You originally mentioned BigDecimal, but the link you gave is for BigInteger.

Can you give me an example of the operations you want to run, and what result you expect?

[BenMorel]

Hi, classes are final to avoid giving access to the protected constructor. The main reason being, if I have to change a protected function in a non-final class, this is considered a BC break, and following semver, this would require releasing a new major version.

This is not (yet) a big deal as v1.0 is not released yet, but I'm interested to know more about your use case, maybe this is something we could add to the library?

[yadakhov]

I'm trying to use base 16 instead of base 10.

Similar to https://github.com/pear/Math_BigInteger/blob/trunk/Math/BigInteger.php#L259. Note the second parameter is the base.

You are correct. Changing the final keyword is a BC break. I'll just fork and create my own version.

Thanks.

[yadakhov]

BigInteger::parse('123456ABCDEF', 16); solves it for me.

Thanks.