Coder Social home page Coder Social logo

Comments (5)

pdietl avatar pdietl commented on May 22, 2024 1

I like the second approach.

from belay.

BrianPugh avatar BrianPugh commented on May 22, 2024

Currently we don't support bytearrays (we do support bytes, however). Belay works on the symmetry of repr serialization and ast.literal_eval deserialization to work. However, I just noticed that ast.literal_eval('b"\x00"') doesn't work (literal_eval doesn't like null bytes), so maybe we should swap it out with a more powerful parser.

EDIT: ok the null byte thing was an escaping issue, however, I'll look into supporting bytearrays

from belay.

BrianPugh avatar BrianPugh commented on May 22, 2024

If we swap out ast.literal_eval with the unsafe eval, we can support bytearrays (as well as any other class who's repr perfectly matches it's constructor). However, this then allows arbitrary execution from a remote device, which doesn't sound like a great idea.

Maybe we can set an "unsafe parsing" boolean that then sets whether or not to use ast.literal_eval vs eval. Thoughts?

from belay.

BrianPugh avatar BrianPugh commented on May 22, 2024

this should be pretty easy; i'll really try to get to this and the pydantic stuff soon.

from belay.

BrianPugh avatar BrianPugh commented on May 22, 2024

closing this issue, further discussion can be done in the PR. I'll be merging and releasing once CI is sorted out (it's like 50% sorted out as of right now).

from belay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.