Coder Social home page Coder Social logo

Comments (5)

brianpkelley avatar brianpkelley commented on May 23, 2024

Thank you for the heads up. I've been rather busy with a newborn and work, I'll try to address asap.

Do you have an example I could look at?

I'll keep this issue open for other people as well.

from video-js-4-plugins.

koenokatachi avatar koenokatachi commented on May 23, 2024

cheers to ur baby ^^ and thanks for ur time

here is a demo http://37.1.195.56/share/vjs/

as is it loads vjs 4.9.1.

u can change the vjs version it loads via the "v" url parameter.
for example http://37.1.195.56/share/vjs/?v=4.8.5 load vjs 4.8.5

what i mean sayin "it doesnt work". open a link and hover the addthis plugin button. in vjs 4.9+ the menu doesnt show itself on the button hovering.

so it works in
http://37.1.195.56/share/vjs/?v=4.5.2
http://37.1.195.56/share/vjs/?v=4.6.4
http://37.1.195.56/share/vjs/?v=4.7.3
http://37.1.195.56/share/vjs/?v=4.8.5

but it doesnt work in
http://37.1.195.56/share/vjs/?v=4.9.1
http://37.1.195.56/share/vjs/?v=4.10.2
http://37.1.195.56/share/vjs/?v=4.11.4
http://37.1.195.56/share/vjs/?v=4.12.5

check out my first comment for some details

from video-js-4-plugins.

brianpkelley avatar brianpkelley commented on May 23, 2024

Can you pull down the latest file and test again. I removed the custom createEl function from the menu button which seems to have fixed the issue.

from video-js-4-plugins.

koenokatachi avatar koenokatachi commented on May 23, 2024

ive updated my demo. yes, it looks like fixed. thanks

from video-js-4-plugins.

brianpkelley avatar brianpkelley commented on May 23, 2024

Thanks for reporting and the help getting this resolved!

from video-js-4-plugins.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.