Coder Social home page Coder Social logo

Comments (6)

brianleroux avatar brianleroux commented on June 11, 2024

I think an exists method is likely what you are looking for... would be easy to add into the LawnchairAdaptorHelpers.js file. Also, given that a store can never really get larger than 2mb I'm ok with iterating over the set until it proves to be actually a user experience problem (not the case for any apps I've used it for).

Wanna give writing exists a go and sending a pull request?

from lawnchair.

timbertson avatar timbertson commented on June 11, 2024

Will do.

With regards to the 2mb limit, why is that? Is that the case for all adapters? (I know why it would be so for the DOM adapter)

from lawnchair.

timbertson avatar timbertson commented on June 11, 2024

I notice it looks like the webkit and gears sqlite adapters will callback(null) from a get() call when an item doesn't exist. Is it worth implementing the same behaviour for the other adapters to keep things consistent?

from lawnchair.

timbertson avatar timbertson commented on June 11, 2024

I've now done the above, and sent a pull request.
exists() might still be useful, but I think the get() callback behaviour is sufficient for now...

from lawnchair.

daviddahl avatar daviddahl commented on June 11, 2024

Perhaps you should just keep an array named "currentKeys" in the data store that knows all of the currently stored keys? searching that is quicker - you just have to make sure you update it each time records are stored or removed.

from lawnchair.

timbertson avatar timbertson commented on June 11, 2024

I could do, but I care a lot more about consistency than speed, and it seem slike a deficiency in functionality.

Anyways, this issue was fixed in commit bcfba8f so I should close it :)

from lawnchair.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.