Comments (6)
I think an exists method is likely what you are looking for... would be easy to add into the LawnchairAdaptorHelpers.js file. Also, given that a store can never really get larger than 2mb I'm ok with iterating over the set until it proves to be actually a user experience problem (not the case for any apps I've used it for).
Wanna give writing exists a go and sending a pull request?
from lawnchair.
Will do.
With regards to the 2mb limit, why is that? Is that the case for all adapters? (I know why it would be so for the DOM adapter)
from lawnchair.
I notice it looks like the webkit and gears sqlite adapters will callback(null) from a get() call when an item doesn't exist. Is it worth implementing the same behaviour for the other adapters to keep things consistent?
from lawnchair.
I've now done the above, and sent a pull request.
exists() might still be useful, but I think the get() callback behaviour is sufficient for now...
from lawnchair.
Perhaps you should just keep an array named "currentKeys" in the data store that knows all of the currently stored keys? searching that is quicker - you just have to make sure you update it each time records are stored or removed.
from lawnchair.
I could do, but I care a lot more about consistency than speed, and it seem slike a deficiency in functionality.
Anyways, this issue was fixed in commit bcfba8f so I should close it :)
from lawnchair.
Related Issues (20)
- indexed-db adapter error in source HOT 6
- Lawnchair, Angular, and Safari HOT 1
- check if the store and its document exists
- Lawnchair 2 ideas from @felixhammerl HOT 3
- Weird behavior between windows HOT 4
- keyPath support for indexed-db adapter HOT 11
- Adapter include vs adapter choice order HOT 2
- a query returns 1 instead of 2 HOT 1
- self.keyExtraction is not a function (webkit-sqlite.js) HOT 2
- UUID, keyPath, webkit-sqlite HOT 1
- Cannot load lawnchair dependency HOT 3
- Can i use it in WebWorker? HOT 1
- Too many transactions queued with IndexedDB adapter HOT 2
- ReferenceError: webkitIDBTransaction is not defined HOT 1
- Object doesn't support property or method 'exists'
- npm package appears to be missing adapters
- Pre-built files HOT 3
- Website is broken HOT 3
- Website is broken
- this lib is not working correctly with Typescript HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lawnchair.