ENUM ARRAY types get parsed as single string about node-pg-types

[charmander]

@Mickael-van-der-Beek That’s expected; you can set its type parser.

=> SELECT typname, oid, typarray FROM pg_type WHERE typname = 'text';
 typname | oid | typarray 
---------+-----+----------
 text    |  25 |     1009
(1 row)

=> SELECT typname, oid, typarray FROM pg_type WHERE typname = 'my_enum';
 typname |  oid   | typarray 
---------+--------+----------
 my_enum | 381744 |   381743
(1 row)

const OID_ARRAY_TEXT = 1009;
const OID_ARRAY_MY_ENUM = 381743;

pg.types.setTypeParser(OID_ARRAY_MY_ENUM, pg.types.getTypeParser(OID_ARRAY_TEXT));

[net]

For any poor souls that find their way here, this will set all existing enum types to be parsed as text:

// node-postgres doesn't properly handle enum arrays out of the box,
// so we have to manually set them up here to parse as text arrays.
//
// https://github.com/brianc/node-pg-types/issues/56

const textArrayOID = (
  await pool.query("SELECT typarray FROM pg_type WHERE typname = 'text'")
).rows[0].typarray;

const enumOIDs = (
  await pool.query("SELECT typname, typarray FROM pg_type WHERE typtype = 'e'")
).rows;

const arrayTextParser = pg.types.getTypeParser(textArrayOID);

enumOIDs.forEach(({ typname, typarray }) => {
  const parser =
    {
      // Parsers for specific types can be set up here, for example:
      // topic_tags: value => arrayTextParser(value).map(s => s.toLowerCase()),
    }[typname] || arrayTextParser;

  pg.types.setTypeParser(typarray, parser);
});

---

Obviously, based on the number of issues pointing here, this should just be the default behavior instead of each downstream library having to re-implement enum array parsing itself. @bendrucker could this be re-opened?

[Mickael-van-der-Beek]

@brianc Would it be possible to know if this is considered a bug or expected behaviour?

[bendrucker]

Querying OID info and registering parsers as you have is clever

this should just be the default behavior

Definitely not. Changing parser registration from sync into async is a big (breaking) change. Coming in hot on a 7 year old issue is not the way to make that kind of change.