Use of village ID or village coordinates instead of village name in the code base about king-bot-api

[breuerfelix]

really good idea ! why did I choose the village name ?

easy to answer, back then I had no gui for the players so the user had to manually insert the village identifier in order to farm in that village.

and for the player to get the village ID he has to scan his network traffic :D so I thought okay he enters the village name and I try to get the correct village from that.

but since we got the gui now... this idea is awesome ! I can add you to the contributors so you can make a branch here in this repo if you want to :) just let me know !

[raj-aayush]

Bug fix implemented. Refer https://github.com/breuerfelix/king-bot-api/commit/b3232ae195806480255039e814f5afb55fb73e31

[raj-aayush]

Aah I see. That explains the functionality. I'm already working on refactoring the village.find() function. I can push it to a separate branch as soon as I'm done with it. Adding me to the contributors list would be very useful and I would really appreciate it.

[breuerfelix]

hey mate, thanks for the refactor !!

just a small annotation, if you fix something next time, it would be cool if you could make a new branch and make a pull request with your changes :)

that way its easier to see what has changes each commit :)

[raj-aayush]

Yeah for sure! I'll keep that in mind. Thanks for the heads up, buddy!

…

On Tue, Aug 27, 2019 at 2:57 AM Felix Breuer ***@***.***> wrote: hey mate, thanks for the refactor !! just a small annotation, if you fix something next time, it would be cool if you could make a new branch and make a pull request with your changes :) that way its easier to see what has changes each commit :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#58?email_source=notifications&email_token=AJLZJ2CB3NK4XAWXAWDMPW3QGTM6XA5CNFSM4HY2XUD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5G3M4I#issuecomment-525186673>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJLZJ2BODOP6LKPRGWHTACTQGTM6XANCNFSM4HY2XUDQ> .