Coder Social home page Coder Social logo

Comments (4)

brentp avatar brentp commented on July 26, 2024

+1. It would be great to have cruzdb support python3. I will work on this at some point. Meanwhile, any pull request would be appreciated.

The Genome.url holds the template for the url. so that can be changed without modifying the code. Then we'd have to adjust create_url to do more careful checking (instead of just mysql:// prefix).

from cruzdb.

lbeltrame avatar lbeltrame commented on July 26, 2024

The only problem is handling all the combinations that SQLAlchemy supports, IMO.

from cruzdb.

brentp avatar brentp commented on July 26, 2024

Can just take an extra argument, eg dialect="oursql".

with the Genome.url as: url = "mysql+%(dialect)://%(user)s%(password)s@%(host)s/%(db)s"
with dialect default to mysqldb.

and adjust the matching which is currently:

    if db.startswith(("sqlite://", "mysql://", "postgresql://")):

to use a regexp for all 3 like "^(sqlite|mysql|postgresql)(+[^:]+)://" # untested

from cruzdb.

lbeltrame avatar lbeltrame commented on July 26, 2024

I'll try to get a PR done, thanks for the suggestions.
What about the unused "engine" parameter?

from cruzdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.