Comments (7)
Did you install as a gem? The gem is from my fork. I hope at some point @brendanlim will do something about this.
from mobile-fu.
I did use the gem, and with that change, everything is working fine. If I forked it and fixed it, do you think he'd respond to a pull request?
from mobile-fu.
No. I'm recommending people consider my fork to be the active one at this stage. If there's bugs in my fork, I'd appreciate pull requests there.
from mobile-fu.
I decided to patch this issue and also rewrite the plugin to use Rails 3 best practices. I also pulled in some of the other pull requests for this branch. If you want, you can check it out here: https://github.com/jyro215/mobile_fu-rails3. Any comments on the code would be very helpful :)
from mobile-fu.
Ok, so apart from using the railtie to extend ActionController, how is this different? I think it's completely off-base to throw that into a new repo and deny @brendanlim's involvement.
from mobile-fu.
I apologize, but that was not my intent at all. I just wanted practice making a rails 3 gem, and I wanted to incorporate some of the pull requests. I'd be happy to make it a fork though.
from mobile-fu.
Ok, I've forked this and made you the primary author in the gemspec. Hope that works better for you.
from mobile-fu.
Related Issues (20)
- set_mobile_format's XHR filter breaks jQuery Mobile HOT 8
- Plugin not Found HOT 1
- mobile-fu and jQuery Mobile HOT 13
- Does not load layout HOT 3
- Gem differs from plugin... issues with gem. HOT 4
- Exclude iPad from mobile view HOT 16
- breaks assets pipeline HOT 2
- Should session[:mobile_view] be checked in is_mobile_device? HOT 3
- fallback to html HOT 11
- rails 3.1 and 3.2 asset pipeline HOT 3
- IE Browsers and False Positives HOT 3
- update regexes list with the ones from Mobile_Detect HOT 1
- how to design screen size? HOT 1
- how to contain view mobile in a new folder HOT 2
- devise not render view mobile when click link HOT 1
- Please close this repo or add link to https://github.com/benlangfeld/mobile-fu HOT 6
- Broken link
- Rails 5 deprecation warning on "before_filter" HOT 1
- Mobile_fu shows Mobile Site to Search Bots (googlebot) instead of Desktop Site HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mobile-fu.