Coder Social home page Coder Social logo

Comments (7)

benlangfeld avatar benlangfeld commented on August 16, 2024

Did you install as a gem? The gem is from my fork. I hope at some point @brendanlim will do something about this.

from mobile-fu.

jorihardman avatar jorihardman commented on August 16, 2024

I did use the gem, and with that change, everything is working fine. If I forked it and fixed it, do you think he'd respond to a pull request?

from mobile-fu.

benlangfeld avatar benlangfeld commented on August 16, 2024

No. I'm recommending people consider my fork to be the active one at this stage. If there's bugs in my fork, I'd appreciate pull requests there.

from mobile-fu.

jorihardman avatar jorihardman commented on August 16, 2024

I decided to patch this issue and also rewrite the plugin to use Rails 3 best practices. I also pulled in some of the other pull requests for this branch. If you want, you can check it out here: https://github.com/jyro215/mobile_fu-rails3. Any comments on the code would be very helpful :)

from mobile-fu.

benlangfeld avatar benlangfeld commented on August 16, 2024

Ok, so apart from using the railtie to extend ActionController, how is this different? I think it's completely off-base to throw that into a new repo and deny @brendanlim's involvement.

from mobile-fu.

jorihardman avatar jorihardman commented on August 16, 2024

I apologize, but that was not my intent at all. I just wanted practice making a rails 3 gem, and I wanted to incorporate some of the pull requests. I'd be happy to make it a fork though.

from mobile-fu.

jorihardman avatar jorihardman commented on August 16, 2024

Ok, I've forked this and made you the primary author in the gemspec. Hope that works better for you.

from mobile-fu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.