Coder Social home page Coder Social logo

Comments (3)

BreakBB avatar BreakBB commented on August 30, 2024

@schichtmschacht Hey, sorry for the late response on this. So you mean the "Spell Bonus" section isn't showing the Holy-Crit correctly?

from extendedcharacterstats.

schichtmschacht avatar schichtmschacht commented on August 30, 2024

Hi, yes, that is correct. The critical strike chance should be above 10% with the talents included, but its only around 5 or 6%, coming from my Intellect stat only.

from extendedcharacterstats.

BreakBB avatar BreakBB commented on August 30, 2024

@schichtmschacht Thanks for your mail. Next time please just reopen the issue :) I'll attach the information you provided here.

first of all I must thank you for the prompt action on the attempt to fix the issue. However I believe that the issue is still there.

It shows (see screenshot) 8,26%, that includes the 5/8 bonus of T1, substract that and you get 6,26%.

Without gear (see screenshot) I have 2,82% meaning that my gear gives me 3,44%.

The 5% from talents do not factor into any of this.

It should be 8,26% + 5% = 13,26%.

I just had a look at the code and already found the issue of this... With the latest release I added the calculation of the new crit value, but didn't use it 🤦‍♂ Sorry about it. I am planning to release a new version very soon.

Screenshots

With gear
image

Without gear
image

from extendedcharacterstats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.