Comments (3)
@ArniDagur I agree, better methods of error logging sound like a great idea and I'd be happy to improve adblock-rust
in this regard.
As it stands, many of the Engine
APIs either return nothing, or are builder-style methods that return another mutable reference to self
. I think the best way to go about this would be:
- For methods that return nothing, return a
Result<(), E>
instead, whereE
is a custom error type denoting the problems that can occur for that particular method. For builder-style methods, it'd be impractical to return aThe builder-style methods are gone as of v0.3.Result
. I'm not sure how commonly these are actually chained together, but I'm not opposed to doing away with the builder-style altogether. Then these can fit in with the first case as well.
Does that sound reasonable?
from adblock-rust.
@AndriusA Hey! I have time over the weekend to work on this. Just tell me how you want it to be done, if at all.
from adblock-rust.
Just pulled out the last few eprintln
cases with 88c1a6b, so I'll consider this fixed!
from adblock-rust.
Related Issues (20)
- `domain` regex syntax
- enforce values on network filter options when possible
- Possible to embed into Firefox ? HOT 2
- Proposal: Browser-level element hiding HOT 4
- Support for `Permissions-Policy` modifier
- Convert $all to $doc like uBO HOT 1
- support AdGuard scriptlet syntax HOT 1
- Will adblock-rust continue to work after Chrome Manifest V3? HOT 3
- `:style()` action operator doesn't work great with some `::-webkit-*` pseudo-classes, if other pseudo classes are used/need in the same rule.
- Support for `$specifichide`
- YouTube blocks default Brave now HOT 2
- Ag filters support of Brave Shields.
- Copyright confusion HOT 9
- Investigate using upstream `url` parser
- uBlock filter not working on Brave, works on Firefox + uBlock HOT 2
- Missing `from` support on `content_blocking.rs` causes crashes
- Wrong types for js bindings HOT 2
- Dependency Dashboard
- Return all filters which blocks the request HOT 1
- Allow specific YouTube channels with the AdBlock HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adblock-rust.